From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+b7f6f8c9303466e16c8a@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [bluetooth?] general protection fault in l2cap_sock_recv_cb
Date: Tue, 11 Jun 2024 10:28:33 +0800 [thread overview]
Message-ID: <tencent_DC337C9ECD1BAD4BFC1B4C25ACBAF1BB7E08@qq.com> (raw)
In-Reply-To: <000000000000b0906d061a468b93@google.com>
please test null ptr defref in l2cap_sock_recv_cb
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cc8ed4d0a848
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index 6db60946c627..6f01920586e6 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -1486,6 +1486,8 @@ static int l2cap_sock_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb)
int err;
lock_sock(sk);
+ l2cap_chan_hold(chan);
+ l2cap_chan_lock(chan);
if (chan->mode == L2CAP_MODE_ERTM && !list_empty(&pi->rx_busy)) {
err = -ENOMEM;
@@ -1534,6 +1536,8 @@ static int l2cap_sock_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb)
}
done:
+ l2cap_chan_unlock(chan);
+ l2cap_chan_put(chan);
release_sock(sk);
return err;
next prev parent reply other threads:[~2024-06-11 2:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 6:02 syzbot
2024-06-11 1:47 ` Edward Adam Davis
2024-06-11 2:15 ` syzbot
2024-06-11 2:28 ` Edward Adam Davis [this message]
2024-06-11 2:47 ` syzbot
2024-06-11 3:00 ` Edward Adam Davis
2024-06-11 3:43 ` syzbot
2024-06-11 4:09 ` Edward Adam Davis
2024-06-11 4:34 ` syzbot
2024-06-11 6:35 ` Edward Adam Davis
2024-06-11 12:05 ` syzbot
2024-06-11 13:27 ` Edward Adam Davis
2024-06-11 14:06 ` syzbot
2024-06-11 14:50 ` [PATCH] bluetooth/l2cap: sync sock recv cb and release Edward Adam Davis
2024-06-11 19:24 ` Luiz Augusto von Dentz
2024-06-12 0:33 ` Edward Adam Davis
2024-06-15 1:45 ` [PATCH v2] " Edward Adam Davis
2024-06-17 19:00 ` patchwork-bot+bluetooth
2024-06-20 16:53 ` Luiz Augusto von Dentz
2024-06-21 14:45 ` [PATCH] " Edward Adam Davis
2024-06-22 3:46 ` Edward Adam Davis
2024-06-24 13:36 ` Luiz Augusto von Dentz
2024-06-25 0:52 ` Edward Adam Davis
2024-06-25 3:08 ` Luiz Augusto von Dentz
2024-06-25 10:12 ` [PATCH V3] Bluetooth/l2cap: " Edward Adam Davis
2024-06-15 1:25 ` [syzbot] [bluetooth?] general protection fault in l2cap_sock_recv_cb Edward Adam Davis
2024-06-15 15:25 ` syzbot
2024-06-21 14:18 ` Edward Adam Davis
2024-06-22 1:25 ` syzbot
2024-06-21 14:56 ` Edward Adam Davis
2024-06-22 3:27 ` syzbot
2024-06-22 8:24 ` Hillf Danton
2024-06-22 9:10 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_DC337C9ECD1BAD4BFC1B4C25ACBAF1BB7E08@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+b7f6f8c9303466e16c8a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®