From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+05b9b39d8bdfe1a0861f@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: [syzbot] [ext4?] [ocfs2?] KASAN: null-ptr-deref Write in jbd2_journal_update_sb_log_tail
Date: Mon, 19 Aug 2024 20:31:59 +0800 [thread overview]
Message-ID: <tencent_E16C702F5D6FE89404EB76ED62CECC783A0A@qq.com> (raw)
In-Reply-To: <000000000000742b9d062005fc1c@google.com>
Journal too short will cause ocfs2_check_volume failed, and will set journal->j_sb_buffer to NULL
#syz test: upstream c3f2d783a459
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
index 530fba34f6d3..25821077b855 100644
--- a/fs/ocfs2/journal.c
+++ b/fs/ocfs2/journal.c
@@ -1077,9 +1077,11 @@ void ocfs2_journal_shutdown(struct ocfs2_super *osb)
BUG_ON(atomic_read(&(osb->journal->j_num_trans)) != 0);
if (ocfs2_mount_local(osb)) {
- jbd2_journal_lock_updates(journal->j_journal);
- status = jbd2_journal_flush(journal->j_journal, 0);
- jbd2_journal_unlock_updates(journal->j_journal);
+ if (journal->j_journal->j_sb_buffer) {
+ jbd2_journal_lock_updates(journal->j_journal);
+ status = jbd2_journal_flush(journal->j_journal, 0);
+ jbd2_journal_unlock_updates(journal->j_journal);
+ }
if (status < 0)
mlog_errno(status);
}
next prev parent reply other threads:[~2024-08-19 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 9:32 syzbot
2024-08-19 11:50 ` Edward Adam Davis
2024-08-19 12:06 ` syzbot
2024-08-19 12:31 ` Edward Adam Davis [this message]
2024-08-19 12:53 ` syzbot
2024-08-19 13:36 ` [PATCH] ocfs2: Fix null-ptr-deref " Edward Adam Davis
2024-08-19 14:43 ` Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_E16C702F5D6FE89404EB76ED62CECC783A0A@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+05b9b39d8bdfe1a0861f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®