From: Edward Adam Davis <eadavis@qq.com>
To: stephen.smalley.work@gmail.com
Cc: eadavis@qq.com, linux-kernel@vger.kernel.org,
omosnace@redhat.com, paul@paul-moore.com,
selinux@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] selinux: access sid under READ/WRITE_ONCE
Date: Wed, 12 Mar 2025 09:05:23 +0800 [thread overview]
Message-ID: <tencent_E8AA2ECB6ED7CC88A7F746FED2C4065B0906@qq.com> (raw)
In-Reply-To: <CAEjxPJ7eFbsn7h7o90tOE6ymp4+g-bwYL_Rwy6t0EcxpaBAxAA@mail.gmail.com>
On Tue, 11 Mar 2025 11:19:49 -0400, Stephen Smalley wrote:
> > Reported-by: syzbot+00c633585760c05507c3@syzkaller.appspotmail.com
> > Closes: https://syzkaller.appspot.com/bug?extid=00c633585760c05507c3
> > Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> > ---
> > V1 -> V2: replace with READ_ONCE/WRITE_ONCE
>
> Thanks for the patch. Did you audit all other users of sksec->sid to
> see if they too should be wrapped with READ_ONCE()/WRITE_ONCE() or are
> already safe?
This fix is only for the issues reported by syzbot+00c633585760c05507c3.
I have confirmed that there are many contexts related to "sksec->sid" (at
least 29). I am not familiar with selinux, and it is unnecessary to do
excessive fixes before syzbot reports other issues.
Maybe the subject of my patch is not appropriate, and it may be more
appropriate to adjust it to "selinux: fix data race in socket create and
receive skb".
BR,
Edward
next prev parent reply other threads:[~2025-03-12 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 0:03 [syzbot] [selinux?] KCSAN: data-race in selinux_socket_post_create / selinux_socket_sock_rcv_skb syzbot
2025-03-09 4:55 ` [PATCH] selinux: read and write sid under lock Edward Adam Davis
2025-03-10 0:39 ` kernel test robot
2025-03-10 2:54 ` kernel test robot
2025-03-10 19:53 ` Stephen Smalley
2025-03-10 20:18 ` Paul Moore
2025-03-11 0:03 ` [PATCH V2] selinux: access sid under READ/WRITE_ONCE Edward Adam Davis
2025-03-11 15:19 ` Stephen Smalley
2025-03-12 1:05 ` Edward Adam Davis [this message]
2025-03-12 13:23 ` Stephen Smalley
2025-03-17 21:39 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_E8AA2ECB6ED7CC88A7F746FED2C4065B0906@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®