From: Weixie Cui <523516579@qq.com>
To: dilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Weixie Cui <cuiweixie@gmail.com>,
Andreas Dilger <adilger@dilger.ca>
Subject: [PATCH v4] ext4: simplify mballoc preallocation size rounding for small files
Date: Wed, 25 Feb 2026 13:02:31 +0800 [thread overview]
Message-ID: <tencent_E9C5F1B2E9939B3037501FD04A7E9CF0C407@qq.com> (raw)
From: Weixie Cui <cuiweixie@gmail.com>
The if-else ladder in ext4_mb_normalize_request() manually rounds up
the preallocation size to the next power of two for files up to 1MB,
enumerating each step from 16KB to 1MB individually. Replace this with
a single roundup_pow_of_two() call clamped to a 16KB minimum, which
is functionally equivalent but much more concise.
Also replace raw byte constants with SZ_1M and SZ_16K from
<linux/sizes.h> for clarity, and remove the stale "XXX: should this
table be tunable?" comment that has been there since the original
mballoc code.
No functional change.
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
---
v4:
- Drop unnecessary braces around single-line if/else as suggested
by Andreas Dilger
v3:
- Replace raw constants with SZ_1M/SZ_16K
- Remove stale XXX comment
---
fs/ext4/mballoc.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 20e9fdaf4301..1d6efba97835 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -4561,22 +4561,16 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac,
(req <= (size) || max <= (chunk_size))
/* first, try to predict filesize */
- /* XXX: should this table be tunable? */
start_off = 0;
- if (size <= 16 * 1024) {
- size = 16 * 1024;
- } else if (size <= 32 * 1024) {
- size = 32 * 1024;
- } else if (size <= 64 * 1024) {
- size = 64 * 1024;
- } else if (size <= 128 * 1024) {
- size = 128 * 1024;
- } else if (size <= 256 * 1024) {
- size = 256 * 1024;
- } else if (size <= 512 * 1024) {
- size = 512 * 1024;
- } else if (size <= 1024 * 1024) {
- size = 1024 * 1024;
+ if (size <= SZ_1M) {
+ /*
+ * For files up to 1MB, round up the preallocation size to
+ * the next power of two, with a minimum of 16KB.
+ */
+ if (size <= (unsigned long)SZ_16K)
+ size = SZ_16K;
+ else
+ size = roundup_pow_of_two(size);
} else if (NRL_CHECK_SIZE(size, 4 * 1024 * 1024, max, 2 * 1024)) {
start_off = ((loff_t)ac->ac_o_ex.fe_logical >>
(21 - bsbits)) << 21;
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-02-25 5:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 5:02 Weixie Cui [this message]
2026-03-01 1:38 ` Weixie Cui
2026-03-01 23:18 ` Andreas Dilger
2026-03-02 15:22 ` Ojaswin Mujoo
2026-04-10 15:18 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_E9C5F1B2E9939B3037501FD04A7E9CF0C407@qq.com \
--to=523516579@qq.com \
--cc=adilger@dilger.ca \
--cc=cuiweixie@gmail.com \
--cc=dilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®