From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+7dbbb74af6291b5a5a8b@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [btrfs?] WARNING: bad unlock balance in btrfs_direct_write
Date: Fri, 2 Aug 2024 19:27:38 +0800 [thread overview]
Message-ID: <tencent_F0F725A60DFF92165D88DDBB9960CF878D07@qq.com> (raw)
In-Reply-To: <000000000000dfd631061eaeb4bc@google.com>
btrfs_sync_file didn't use skip_ilock to split up_write and btrfs_inode_unlock
#syz test: upstream e4fc196f5ba3
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 9f10a9f23fcc..9914419f3b7d 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1868,7 +1868,10 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
out_release_extents:
btrfs_release_log_ctx_extents(&ctx);
- btrfs_inode_unlock(inode, BTRFS_ILOCK_MMAP);
+ if (skip_ilock)
+ up_write(&inode->i_mmap_lock);
+ else
+ btrfs_inode_unlock(inode, BTRFS_ILOCK_MMAP);
goto out;
}
next prev parent reply other threads:[~2024-08-02 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 7:59 syzbot
2024-08-02 11:27 ` Edward Adam Davis [this message]
2024-08-02 11:51 ` syzbot
2024-08-02 11:54 ` [PATCH] btrfs: Add missing skip-lock for locks Edward Adam Davis
2024-08-02 12:29 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_F0F725A60DFF92165D88DDBB9960CF878D07@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+7dbbb74af6291b5a5a8b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®