Re: [PATCH] USB: serial: option: add UNISOC(Spreadtrum) UIS7720

[Renjun Wang <renjunw0@foxmail.com>]

Hi Greg,

On 10/19/25 19:16, Greg KH wrote:
> On Sun, Oct 19, 2025 at 06:44:38PM +0800, Renjun Wang wrote:
>> Add support for UNISOC(Spreadtrum) UIS7720(A7720) module.
>>
>> T:  Bus=05 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  5 Spd=480 MxCh= 0
>> D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
>> P:  Vendor=1782 ProdID=4064 Rev=04.04
>> S:  Manufacturer=Unisoc-phone
>> S:  Product=Unisoc-phone
>> S:  SerialNumber=0123456789ABCDEF
>> C:  #Ifs= 9 Cfg#= 1 Atr=c0 MxPwr=500mA
>> I:  If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host
>> E:  Ad=82(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
>> I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host
>> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 7 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I:  If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
>> E:  Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>>
>> 0&1: RNDIS, 2: LOG, 3: DIAG, 4&5: AT Ports, 6&7: AT2 Ports, 8: ADB
>>
>> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
>> ---
>>   drivers/usb/serial/option.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index 62e984d20e59..667de914a5eb 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -619,6 +619,7 @@ static void option_instat_callback(struct urb *urb);
>>   #define TOZED_PRODUCT_LT70C			0x4055
>>   /* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */
>>   #define LUAT_PRODUCT_AIR720U			0x4e00
>> +#define UNISOC_PRODUCT_UIS7720			0x4064
> Shouldn't this be in sorted order?
>
> thanks,
>
> greg k-h

I think it is not needed for this. As the information got from UNISOC 
official website,

these three products are  applied for different solutions(catalogs). 
UIS8910 is applied for

industrial IoT solutions[1] with 28nm process, and UIS7720 is applied 
for smart cockpit

solutions[2] with 6nm process.

[1] https://www.unisoc.com/en/solution/IndustryInternectUS/8910DM

[2] https://www.unisoc.com/en/solution/IGCockpitSolutionUS/A7720


Best Regards,

Renjun Wang