mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shengminghu512 <shengminghu512@qq.com>
To: akpm <akpm@linux-foundation.org>, vbabka <vbabka@suse.cz>,
	surenb <surenb@google.com>, mhocko <mhocko@suse.com>,
	jackmanb <jackmanb@google.com>, hannes <hannes@cmpxchg.org>
Cc: ziy <ziy@nvidia.com>, inux-mm <inux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"hu.shengming" <hu.shengming@zte.com.cn>,
	"zhang.run" <zhang.run@zte.com.cn>
Subject: [PATCH linux-next] mm/page_alloc: avoid overcounting bulk alloc in watermark check
Date: Thu, 29 Jan 2026 22:38:14 +0800	[thread overview]
Message-ID: <tencent_F36C5B5FB4DED98C79D9BDEE1210CD338C06@qq.com> (raw)

From: Shengming Hu <hu.shengming@zte.com.cn>

alloc_pages_bulk_noprof() only fills NULL slots and already tracks how many
entries are pre-populated via nr_populated.

The fast watermark check was adding nr_pages unconditionally, which can
overestimate the demand. Use (nr_pages - nr_populated) instead, as an 
upper bound on the remaining pages this call can still allocate without
scanning the whole array.

Signed-off-by: Shengming Hu <hu.shengming@zte.com.cn>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5fd9e4a03..90b978802 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5130,7 +5130,7 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid,
 
 		cond_accept_memory(zone, 0, alloc_flags);
 retry_this_zone:
-		mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK) + nr_pages;
+		mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK) + nr_pages - nr_populated;
 		if (zone_watermark_fast(zone, 0,  mark,
 				zonelist_zone_idx(ac.preferred_zoneref),
 				alloc_flags, gfp)) {
-- 
2.25.1

             reply	other threads:[~2026-01-29 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 14:38 shengminghu512 [this message]
2026-01-29 22:10 ` Andrew Morton
2026-01-30  0:29   ` [PATCH linux-next] mm/page_alloc: avoid overcounting bulk allocin " shengminghu512
2026-02-12 15:57 ` [PATCH linux-next] mm/page_alloc: avoid overcounting bulk alloc in " Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_F36C5B5FB4DED98C79D9BDEE1210CD338C06@qq.com \
    --to=shengminghu512@qq.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hu.shengming@zte.com.cn \
    --cc=inux-mm@kvack.org \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=zhang.run@zte.com.cn \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®