From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=203.205.221.240 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795248364; b=SHeV/nq1tTNCrxXjoTOogGVpSG9LkNv+ED2nvgDJ3cm8f1AvRHLC3eUJx2GmSCEoIqUx L+nR6Z90m6bkLq9HIp3ceVZUGr0ARu4lnB2p8w8h7ugGsF1EF2oJlt7v3mcu7UiniIcnF EKvi+auqNDfXmIaU6OY4OlDF9ZgPLYQG7D7pklRS16RQZsrboBn4Eyc00lFKAPDmy1BRt 0qbr6UEAKa5W0noAVf+W8TAR6VVBvNsTfJTbk8nHrDINjSbdFhXZDeQ+paFRzwbvcHAo+ I+0aEv48rnHvzOQf7dCGyX5tX2pD2ICjELqoqRMmhr5s3OescnyJlc4I/nSU5YGvdgw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795248364; h=DMARC-Filter:DKIM-Signature:Received:X-QQ-mid:Message-ID: X-QQ-XMAILINFO:X-QQ-XMRINFO:From:To:Cc:Subject:Date:X-OQ-MSGID: X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=e3aB6iEl4AhdDI4c3BawDm+/eHLIPD2LaHMqVk0Sdzg=; b=ejo6wmq8eocF8t+f+4n4iznMBGze6ka/+06h0/8yDUX9QKuDUslzjWCKxazeaN3D8v+e 5kQKbK2PrlQiAddn34eAhOHg880lZREQYmYo7p1VSsQO2fqtyAWesGmiTvPntXa23Oc/I arAzYwPBjic3Gwwf2MDRjbY225XDfc1BNDQUGrYaiHOmxIzSZHh6LFvJcP3HyxHxpAE6G zIZZL1+beGD4/Ns1a91RzDx+qC16TeshxuhY/a8Zt1vR6JUsEn4Q1QK3Me8U3rC2qT+S+ HsmIFgfmgJvmuDWWRaqZRUXgO0Z2gppcoISJebGARtdJjxZ8wVteuiu8rwKL/RdmMzg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass header.d=qq.com header.i=@qq.com header.a=rsa-sha256 header.s=s201512 header.b=MHj78Ez0; arc=none smtp.remote-ip=203.205.221.240 Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB535606A325 for ; Sat, 21 Nov 2026 08:06:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DB535606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.a=rsa-sha256 header.s=s201512 header.b=MHj78Ez0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1795248362; bh=e3aB6iEl4AhdDI4c3BawDm+/eHLIPD2LaHMqVk0Sdzg=; h=From:To:Cc:Subject:Date; b=MHj78Ez0kGZfRUqTrib13DOVT+rENAitcIQQOK/L9NyE3N4F5HvoRpqK3P66PboW6 4G+l6t9qXnEmH+gpiNaWEAnIgO4hLtOBw6m7CaCtFm7Py5fd3owqz2yXkpKGiSbQls dDRQaRIVdGQg/QGhq2SBtkDReqKTK2ROep83nOyU= Received: from jerry-PC.lan ([2408:8249:5f:7101:71a:8713:56b4:5043]) by newxmesmtplogicsvrszc56-0.qq.com (NewEsmtp) with SMTP id 17A90CFC; Sat, 21 Nov 2026 16:05:58 +0800 X-QQ-mid: xmsmtpt1795248358txeicc0pc Message-ID: X-QQ-XMAILINFO: MpgQwYiCXBoUm/Z8Sfca4XktQRA8tw5RyhLqUGRZyPrIye9TkwBe5RMw1mCGIo nIeB+le+vA2nm6GT7Rd6s4LrY97UoXH785690q0DwG1Jsk8PTr8bvZKrGUerWqrQfz5lzktslE+4 KKzjBTfulgpfyllLsb7tRY7tbUi/ezP9u4IlHNtGiVJuA8FkUQ6wNcHMbrGg/cs4ktwVIiITXoPL Vu1p/kvIdWfybk4xlYJw9aXkiCmJ68GAaVX59+BZrbiIJAlOmvnl0sb2LxQdoDMyPTzn7NevovAn CTRfRjt7HstnFtdqAvGZS4qNb1XXNGJltcEKfjpp02SOQt6Wz7J0H6BSpEY1I5y54wAl22foINNu PYowToD/t9LpPoU3miVssMgTIhEDNUD/I2geOC+FM/jZ/yU3jjQHj6iMVA19GYRwR3RyePUcTvia vziSHDBDmi6FonqZ7TfC1se0LsBQKjpBYj6riExeOpbVQSmYx6y0FltaIUA7YJi51z2WByIOOcG1 KMmem5R0xF9ODrRZ6WraXAAc3tzAlKNcvOWBC1rnlZGRik5k7XJB51dz3C1xoHlfMTewbWTsesKG wKI4t0FIQKpZHsFu4Ofk0VcPjhxnnSKwORWfCLG+rhPQBIn3Nyem7MatQY9rFvyuJxvxc+QP8vJf AKoWEhnUOToLjDFO+Y38fqoSYRx2O87KscRhkhivamLQFca/An7u05HaX1eZ15hmcKmorqtwEkYZ ptkl7t15Ke67k2qITsPCc6+8adJJKTLPkqxI4fJyClAgsNvr0DFE4q3F8qd9Gfeo+q6/a2/7ACPL 0oHwaDVWapaPj518OK6ncQySZZOTN77d86E4bLcv6lOivu2zSuX5TaocpBIQTv410VhIPALV+gvW nvdnsbnBtPEF6II/tCGXdsvUgAmGm6AniVI2okmgw1Ki6R0zEX1bQveuyZEpqs4vRfjxdXFAxkwJ yC4c2/5hdyztVxskS2sKCsctUBlhMzfqXTjlHxmdl3f721dd/Oqfs3E1TUxyCoEBRQslpbZQlCxp iS27TKtaS/TCXaYSFPzjylgOym6B0xWGhrcTsEw8FDFxZmHgHVpgNalV9zLp8g/aWG4E3aRX7Rmq 8dGRSWvFBYeklmgNemJPq3XoBJz2y+QpW8xCQuTjjZ3zXhz55Mh5TtqlfzFWI5NAbdgbDNL+PPCy p0CD/DRgZuZYuNkPqbZbQDltNkEcuOgQO3O7I= X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== From: ZhuXiangyu <1194781887@qq.com> To: Vinod Koul , Neil Armstrong , Heiko Stuebner , Sandy Huang Cc: Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Manivannan Sadhasivam , linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, ZhuXiangyu <1194781887@qq.com> Subject: [PATCH] drm/phy: rockchip: fix RK3506 DSI low-power command handling Date: Sat, 21 Nov 2026 16:05:55 +0800 X-OQ-MSGID: <20261121080555.1289195-1-1194781887@qq.com> X-Mailer: git-send-email 2.47.3 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two bugs keep the RK3506 MIPI-DSI link from initialising a panel: the DPHY programs the wrong high-speed timing entry, and the PHY data lanes are never enabled in the GRF. 1. phy-rockchip-inno-dsidphy picks the wrong HS timing entry The 1.5 GHz inno DSI PHY timing table stores its rates in Mbps while the other tables and the lookup use Hz. The mode enable code compares inno->pll.rate in Hz (e.g. 372000000) against timings[].rate in Mbps (e.g. 400), so the comparison never matches. The loop runs to the end and the last, fastest entry is used, which programs a TLPX/LPX counter that is far too large. The panel then cannot decode the low-power DCS commands and stays in sleep mode, so the display stays black even though the LP packets are visible on the data lane. Convert the 1.5 GHz timing table rates to Hz so that the lookup selects the correct entry. 2. The RK3506 DSI GRF lane enable bits are never written rk3506_chip_data only clears the turnaround / force-stop fields, so the PHY data lanes stay disabled unless the boot loader happens to enable them. Program RK3506_DSI_PHY_ENABLE_LANE0/1 as well. Tested on the RK3506B JerryTech board: the panel now receives the init sequence over LP and the framebuffer console is visible. Fixes: 785a9d5bb145 ("phy: rockchip: inno-dsidphy: Add support for rk3506") Fixes: cabeacc7eadc ("drm/rockchip: dsi: Add support for rk3506") Signed-off-by: ZhuXiangyu <1194781887@qq.com> --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 6 +++- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 28 +++++++++---------- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c index 30d6f83c..116cc140 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c @@ -199,6 +199,8 @@ #define RK3506_SYS_GRF_SOC_CON6 0x0018 #define RK3506_DSI_FORCETXSTOPMODE (0xf << 4) +#define RK3506_DSI_PHY_ENABLE_LANE1 BIT(9) +#define RK3506_DSI_PHY_ENABLE_LANE0 BIT(8) #define RK3506_DSI_TURNDISABLE BIT(2) #define RK3506_DSI_FORCERXMODE BIT(0) @@ -1727,7 +1729,9 @@ static const struct rockchip_dw_dsi_chip_data rk3506_chip_data[] = { .lanecfg1_grf_reg = RK3506_SYS_GRF_SOC_CON6, .lanecfg1 = (FIELD_PREP_WM16_CONST(RK3506_DSI_TURNDISABLE, 0) | FIELD_PREP_WM16_CONST(RK3506_DSI_FORCERXMODE, 0) | - FIELD_PREP_WM16_CONST(RK3506_DSI_FORCETXSTOPMODE, 0)), + FIELD_PREP_WM16_CONST(RK3506_DSI_FORCETXSTOPMODE, 0) | + FIELD_PREP_WM16_CONST(RK3506_DSI_PHY_ENABLE_LANE0, 1) | + FIELD_PREP_WM16_CONST(RK3506_DSI_PHY_ENABLE_LANE1, 1)), .max_data_lanes = 2, .max_bit_rate_per_lane = 1500000000UL, .dphy_get_timing = dw_mipi_dsi_phy_px30_get_timing, diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c index 6ad04b0c..fcf7aa17 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c @@ -282,20 +282,20 @@ struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_1ghz[] = { static const struct inno_mipi_dphy_timing inno_mipi_dphy_timing_table_max_1_5ghz[] = { - { 110, 0x02, 0x7f, 0x16, 0x02, 0x02}, - { 150, 0x02, 0x7f, 0x16, 0x03, 0x02}, - { 200, 0x02, 0x7f, 0x17, 0x04, 0x02}, - { 250, 0x02, 0x7f, 0x17, 0x05, 0x04}, - { 300, 0x02, 0x7f, 0x18, 0x06, 0x04}, - { 400, 0x03, 0x7e, 0x19, 0x07, 0x04}, - { 500, 0x03, 0x7c, 0x1b, 0x07, 0x08}, - { 600, 0x03, 0x70, 0x1d, 0x08, 0x10}, - { 700, 0x05, 0x40, 0x1e, 0x08, 0x30}, - { 800, 0x05, 0x02, 0x1f, 0x09, 0x30}, - {1000, 0x05, 0x08, 0x20, 0x09, 0x30}, - {1200, 0x06, 0x03, 0x32, 0x14, 0x0f}, - {1400, 0x09, 0x03, 0x32, 0x14, 0x0f}, - {1500, 0x0d, 0x42, 0x36, 0x0e, 0x0f}, + { 110000000, 0x02, 0x7f, 0x16, 0x02, 0x02}, + { 150000000, 0x02, 0x7f, 0x16, 0x03, 0x02}, + { 200000000, 0x02, 0x7f, 0x17, 0x04, 0x02}, + { 250000000, 0x02, 0x7f, 0x17, 0x05, 0x04}, + { 300000000, 0x02, 0x7f, 0x18, 0x06, 0x04}, + { 400000000, 0x03, 0x7e, 0x19, 0x07, 0x04}, + { 500000000, 0x03, 0x7c, 0x1b, 0x07, 0x08}, + { 600000000, 0x03, 0x70, 0x1d, 0x08, 0x10}, + { 700000000, 0x05, 0x40, 0x1e, 0x08, 0x30}, + { 800000000, 0x05, 0x02, 0x1f, 0x09, 0x30}, + {1000000000, 0x05, 0x08, 0x20, 0x09, 0x30}, + {1200000000, 0x06, 0x03, 0x32, 0x14, 0x0f}, + {1400000000, 0x09, 0x03, 0x32, 0x14, 0x0f}, + {1500000000, 0x0d, 0x42, 0x36, 0x0e, 0x0f}, }; static const -- 2.47.3