From: xiaopeitux@foxmail.com
To: cryolitia@uniontech.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pei Xiao <xiaopei01@kylinos.cn>
Subject: [PATCH v2 3/3] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure
Date: Wed, 27 May 2026 16:10:56 +0800 [thread overview]
Message-ID: <tencent_F6CCA9B9DA441472AB5119417E7B619DB40A@qq.com> (raw)
In-Reply-To: <cover.1779868768.git.xiaopei01@kylinos.cn>
From: Pei Xiao <xiaopei01@kylinos.cn>
When platform_create_bundle() fails, the error is fatal and prevents the
driver from loading. Use pr_err() instead of pr_warn() to clearly indicate
a critical failure.
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
drivers/hwmon/gpd-fan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index 745b3fb9e3a4..b18725f4d108 100644
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -712,7 +712,7 @@ static int __init gpd_fan_init(void)
match, sizeof(*match));
if (IS_ERR(gpd_fan_platform_device)) {
- pr_warn("Failed to create platform device\n");
+ pr_error("Failed to create platform device\n");
return PTR_ERR(gpd_fan_platform_device);
}
--
2.25.1
next prev parent reply other threads:[~2026-05-27 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1779868768.git.xiaopei01@kylinos.cn>
2026-05-27 8:10 ` [PATCH v2 1/3] hwmon: (gpd-fan): drop global driver data and use per-device allocation xiaopeitux
2026-05-27 8:15 ` Pei Xiao
2026-05-27 8:10 ` [PATCH v2 2/3] hwmon: (gpd-fan): Initialize EC before registering hwmon device xiaopeitux
2026-05-27 8:10 ` xiaopeitux [this message]
2026-05-27 9:26 ` [PATCH v2 3/3] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure Pei Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_F6CCA9B9DA441472AB5119417E7B619DB40A@qq.com \
--to=xiaopeitux@foxmail.com \
--cc=cryolitia@uniontech.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®