From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E75C83F11 for ; Tue, 29 Aug 2023 00:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234650AbjH2AsU (ORCPT ); Mon, 28 Aug 2023 20:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234663AbjH2Arx (ORCPT ); Mon, 28 Aug 2023 20:47:53 -0400 Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F3013D; Mon, 28 Aug 2023 17:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1693270062; bh=LxUutieyTDutRI1JM5YEeCPiPo1Dpb9gHQrtgvK0grI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=koIrWq6cwt0dYLGXnXiBA9XbHAWYLFoasGNfCdo7VacjfLWZdlINsJRtpZBUmMDwJ +6vKi7rNlANRMz5uhtGlJQx2lskLAJJg8xXuRtAMLcn+a6f0mDpQ+OJVkj0Gt3qVzl PONwmmLrJ8d5TFbFu5ThaAEVQl91VWooW0j77wQk= Received: from localhost.localdomain ([39.156.73.12]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id BE3B6E68; Tue, 29 Aug 2023 08:47:35 +0800 X-QQ-mid: xmsmtpt1693270055tucwvy5he Message-ID: X-QQ-XMAILINFO: MGSlRwRrdVfIisT3TiXB4uYFg1pb70VmVj01DWlSdnyXveEPvcdfOti4Q7+mlg 3vm370upAN81LRC9/x3JRq4rGtFv69eq7BpBUc1EIO+ezuZzWYVks3EJByyg33EydPy8vrJgieNS 2Z6R9SZeFE0PPT1HDn6njhxKOuw48AlXhRpqKEmqSywXA8XjPOoqEiGgdqOlQac+iLAKxljaBvJo hF2RrRCPHzbv8DGPEAg9L6I5jCgZf6ZyGsVU20EXN2wcsHoReJuJJ0XfAVXbdkLlFupuABXVqHGu jd0VcB1p4gSRIpfl18m7I5bw/HVILqal4kLI7npc5mrVwGOpw/B8P3HDRnVKEAeTtM4loIKSfGfS uBgjc9H16GM95fCAsPgbYiEGWRRJX5CCNm2BxAlmAjeuir0qzLhq0BRO91mwTi2D6INeC95OiU/n I0kagyzaInYM/CnD8K5UIVeQyVn/taydaNjrw1THMkVfxzDO5nmYc3OWAikwAtSeGidmXCYn/6DL uKIReuw1Iv9bNPKUx9Rya9fvMk/equbsebS5l0Rvy1zVcaOzkBPf45R4sxlmAzJ3mndd9M2G8UyY 470Ch9UnwI7OXBFRZrpc+wXu12kUXqtNazHb2D7BoL/dlwSzWtA/+o4fz8DqJZpisd7zED0yg5yx 54Ywr4nKB8tVu9V3SwgFS7MaKdL7P4JmPg8S3+goUu/bJom6I+PiviJxNzMxFzAfNnTooEfwiRno yaUpEtGelmDznC95nZYnsHD1TQxoDgWPLI1OkU8AO7bcqSUnIMa7C6GB4zhimzed/uiL4wInWQvC JqsML0mv6f6htaA3tCIEOlI+mu/ucVinF85nNJobmVUVe1e6p+q++qkzrtlW3oZIHdCNylaIC25g ct0J8TTWg0ujX7S83T4uc/Yg0zFh+0qFWVe/ukPQBfVn8blD5/VHPcJm/OnTpTO/UZICgMDLr0oS K3zDZM5OqIvEwHsJEbRJRndGKzShRoSxMqY3/3Kf6VHbv54j84pYcOUjkl9ev3 X-QQ-XMRINFO: MPJ6Tf5t3I/ycC2BItcBVIA= From: Rong Tao To: olsajiri@gmail.com Cc: alexandre.torgue@foss.st.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, chantr4@gmail.com, daniel@iogearbox.net, deso@posteo.net, eddyz87@gmail.com, haoluo@google.com, iii@linux.ibm.com, john.fastabend@gmail.com, kpsingh@kernel.org, laoar.shao@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, martin.lau@linux.dev, mcoquelin.stm32@gmail.com, mykolal@fb.com, rongtao@cestc.cn, rtoax@foxmail.com, sdf@google.com, shuah@kernel.org, song@kernel.org, xukuohai@huawei.com, yonghong.song@linux.dev, zwisler@google.com Subject: Re: [PATCH bpf-next v8] selftests/bpf: trace_helpers.c: optimize kallsyms cache Date: Tue, 29 Aug 2023 08:47:35 +0800 X-OQ-MSGID: <20230829004735.99516-1-rtoax@foxmail.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Hi, jirka. Thanks for your reply. > > > > > > @@ -164,13 +165,14 @@ int main(int argc, char **argv) > > > > } > > > > > > > > /* initialize kernel symbol translation */ > > > > - if (load_kallsyms()) { > > > > + ksyms = load_kallsyms(); > > > > > > if we keep the load_kallsyms/ksym_search/ksym_get_addr functions as described > > > in [1] the samples/bpf would stay untouched apart from the Makefile change > > > > Maybe we should make this modification, wouldn't it be better? After all, > > not modifying the source code of samples/bpf is not really a reason not to > > make modifications to load_kallsyms(), what do you think? > > I think we want separate selftest and samples changes and I don't see > other way to do that Thanks, jirka, I didn't notice this in the previous discussion, sorry. Let me try to solve this problem. Rong Tao