mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hang Nan <2122295973@qq.com>
To: matttbe@kernel.org
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	martineau@kernel.org, geliang@kernel.org, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, kuniyu@google.com, willemb@google.com,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	2122295973@qq.com
Subject: Re: [PATCH net v5 0/3] mptcp token hash ordering and token 0 lookups
Date: Fri, 20 Nov 2026 20:17:56 +0800	[thread overview]
Message-ID: <tencent_F83D2E71F8533412D7D7477A7ED9F6459B06@qq.com> (raw)
In-Reply-To: <20261116145829.96849-1-2122295973@qq.com>

Hi Matt,

thanks, all points taken.  v6 is prepared but not sent: I will wait for
Netdev Sashiko to finish, as you asked.

- Threading: I see the same thing you do on lore.  The patches are sent
  with git send-email, which sets In-Reply-To to the Message-ID it assigned
  to the cover letter, but our relay rewrites Message-ID on the way out
  (the tencent_*... IDs on lore are not the ones the client wrote), so the
  children end up pointing at an ID that never existed publicly.  I have
  not found a way to make that relay preserve the header; if you have a
  suggestion that works with such a relay I would take it, otherwise I will
  send the next version in a way that does not depend on the rewritten ID.

- Prefix: switched to "mptcp: " in v6.

- KUnit test: dropped.  Beyond your point that a !token guard is not worth
  50 lines, it also caused the build failure the test robot reported - the
  case used mptcp_token_exists(), which is not exported, so
  mptcp_token_test.ko failed at modpost when the test is built as a module.
  The pre-existing token tests pass with the series: pass:4 fail:0.

- For backports I kept the code changes as three separate commits (ordering,
  hash-membership check, token 0), so none of them carries test code.

- token 0: v6 says explicitly that no connection gets token 0 from this
  implementation, and that the RFC 8684 token field does allow zero, so the
  rejection is a Linux-side property, not a protocol one.

Two things I folded in from the Sashiko review of the same series, which
you may want to look at when you do the full review:

- [High] The acquire ordering does not cover the passive-open path, where
  sk_clone() publishes the refcount before mptcp_sk_clone_init() sets the
  token.  v6 adds a separate patch that drops a socket which is no longer
  on the chain after the increment, the way __inet_lookup_established()
  does.

- [Low] The stable tag now names the dependency:
  "Cc: stable@vger.kernel.org" plus a sentence pointing at
  7f8ceea0c580 ("refcount: provide ops for cases when object's memory can
  be reused") in the body.

Cheers,
Hang


  parent reply	other threads:[~2026-11-20 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261116145829.96849-1-2122295973@qq.com>
2026-11-16 14:58 ` [PATCH net v5 1/3] net: mptcp: take token lookup references with acquire ordering Hang Nan
2026-11-16 14:58 ` [PATCH net v5 2/3] net: mptcp: reject token 0 in mptcp_token_get_sock() Hang Nan
2026-11-17  6:44   ` kernel test robot
2026-11-16 14:58 ` [PATCH net v5 3/3] net: mptcp: verify the token slot in mptcp_token_iter_next() Hang Nan
2026-11-20 12:17 ` Hang Nan [this message]
2026-11-16 14:58 [PATCH net v5 0/3] mptcp token hash ordering and token 0 lookups Hang Nan
2026-11-18 10:50 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_F83D2E71F8533412D7D7477A7ED9F6459B06@qq.com \
    --to=2122295973@qq.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®