From: "tip-bot for Bryan O'Donoghue" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
pure.logic@nexus-software.ie, tglx@linutronix.de
Subject: [tip:x86/platform] x86/intel/quark: Add comment on TLB flush to setup_arch()
Date: Wed, 24 Sep 2014 21:54:40 -0700 [thread overview]
Message-ID: <tip-02276a3a677d681f0cd227d7111c71fdbce23832@git.kernel.org> (raw)
In-Reply-To: <1411590363-8052-1-git-send-email-pure.logic@nexus-software.ie>
Commit-ID: 02276a3a677d681f0cd227d7111c71fdbce23832
Gitweb: http://git.kernel.org/tip/02276a3a677d681f0cd227d7111c71fdbce23832
Author: Bryan O'Donoghue <pure.logic@nexus-software.ie>
AuthorDate: Wed, 24 Sep 2014 21:26:03 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 25 Sep 2014 06:52:15 +0200
x86/intel/quark: Add comment on TLB flush to setup_arch()
Quark X1000 requires CR3 to be rewritten to flush TLB entries
irrespective of the PGE bits in CR4 or PTE.PGE.
Add a comment to setup_arch() to indicate that the code:
load_cr3(swapper_pg_dir);
__flush_tlb_all();
Will already have flushed the TLB @ the CR3 reload allowing us
to skip over a potential if/else for Quark.
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Link: http://lkml.kernel.org/r/1411590363-8052-1-git-send-email-pure.logic@nexus-software.ie
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/setup.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 41ead8d..e7d7f6e 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -878,6 +878,11 @@ void __init setup_arch(char **cmdline_p)
initial_page_table + KERNEL_PGD_BOUNDARY,
KERNEL_PGD_PTRS);
+ /*
+ * Locate the page directory and flush the TLB.
+ * On Quark X1000 rewriting CR3 flushes the TLB no if/else is required
+ * to choose between __flush_tlb() and __flush_tlb_all()
+ */
load_cr3(swapper_pg_dir);
__flush_tlb_all();
#else
prev parent reply other threads:[~2014-09-25 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 20:26 [PATCH] x86: Quark: Add comment on TLB flush to setup_arch Bryan O'Donoghue
2014-09-25 4:54 ` tip-bot for Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-02276a3a677d681f0cd227d7111c71fdbce23832@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome