From: tip-bot for Patrick Pannuto <ppannuto@codeaurora.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
joe@perches.com, akpm@linux-foundation.org, tglx@linutronix.de,
ppannuto@codeaurora.org
Subject: [tip:timers/core] Checkpatch: Prefer usleep_range over udelay
Date: Wed, 4 Aug 2010 09:25:55 GMT [thread overview]
Message-ID: <tip-022d60db2ab6e97f93c98808d08fd883003048c7@git.kernel.org> (raw)
In-Reply-To: <1280786467-26999-4-git-send-email-ppannuto@codeaurora.org>
Commit-ID: 022d60db2ab6e97f93c98808d08fd883003048c7
Gitweb: http://git.kernel.org/tip/022d60db2ab6e97f93c98808d08fd883003048c7
Author: Patrick Pannuto <ppannuto@codeaurora.org>
AuthorDate: Mon, 2 Aug 2010 15:01:06 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 4 Aug 2010 11:00:45 +0200
Checkpatch: Prefer usleep_range over udelay
When possible, sleeping is (usually) better than delaying;
however, don't bother callers of udelay < 10us, as those
cases are generally not worth the switch to usleep
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
Cc: apw@canonical.com
Cc: corbet@lwn.net
Cc: arjan@linux.intel.com
Cc: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1280786467-26999-4-git-send-email-ppannuto@codeaurora.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
scripts/checkpatch.pl | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..1698c63 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2570,6 +2570,14 @@ sub process {
}
}
+# prefer usleep_range over udelay
+ if (($line =~ /\budelay\s*\(\s*(\w+)\s*\)/ {
+ # ignore udelay's < 10, however
+ if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
+ CHK("usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
+ }
+ }
+
# warn about #ifdefs in C files
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
# print "#ifdef in C files should be avoided\n";
next prev parent reply other threads:[~2010-08-04 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 22:01 [PATCH v3 0/4] Add usleep_range Patrick Pannuto
2010-08-02 22:01 ` [PATCH 1/4] timer: Added usleep_range timer Patrick Pannuto
2010-08-03 22:51 ` Andrew Morton
2010-08-02 22:01 ` [PATCH 2/4] Documentation: Add timers/timers-howto.txt Patrick Pannuto
2010-08-04 9:25 ` [tip:timers/core] " tip-bot for Patrick Pannuto
2010-08-02 22:01 ` [PATCH 3/4] Checkpatch: prefer usleep_range over udelay Patrick Pannuto
2010-08-04 9:25 ` tip-bot for Patrick Pannuto [this message]
2010-08-04 23:23 ` [tip:timers/core] Checkpatch: Prefer " Patrick Pannuto
2010-08-02 22:01 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto
2010-08-04 9:26 ` [tip:timers/core] Checkpatch: Warn " tip-bot for Patrick Pannuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-022d60db2ab6e97f93c98808d08fd883003048c7@git.kernel.org \
--to=ppannuto@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome