From: tip-bot for Pavel Tatashin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
tglx@linutronix.de, hpa@zytor.com, pasha.tatashin@oracle.com
Subject: [tip:x86/timers] x86/tsc: Split native_calibrate_cpu() into early and late parts
Date: Thu, 19 Jul 2018 15:34:28 -0700 [thread overview]
Message-ID: <tip-03821f451d2d2d7599061244734245be139014ea@git.kernel.org> (raw)
In-Reply-To: <20180719205545.16512-26-pasha.tatashin@oracle.com>
Commit-ID: 03821f451d2d2d7599061244734245be139014ea
Gitweb: https://git.kernel.org/tip/03821f451d2d2d7599061244734245be139014ea
Author: Pavel Tatashin <pasha.tatashin@oracle.com>
AuthorDate: Thu, 19 Jul 2018 16:55:44 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 20 Jul 2018 00:02:44 +0200
x86/tsc: Split native_calibrate_cpu() into early and late parts
During early boot TSC and CPU frequency can be calibrated using MSR, CPUID,
and quick PIT calibration methods. The other methods PIT/HPET/PMTIMER are
available only after ACPI is initialized.
Split native_calibrate_cpu() into early and late parts so they can be
called separately during early and late tsc calibration.
Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: steven.sistare@oracle.com
Cc: daniel.m.jordan@oracle.com
Cc: linux@armlinux.org.uk
Cc: schwidefsky@de.ibm.com
Cc: heiko.carstens@de.ibm.com
Cc: john.stultz@linaro.org
Cc: sboyd@codeaurora.org
Cc: hpa@zytor.com
Cc: douly.fnst@cn.fujitsu.com
Cc: peterz@infradead.org
Cc: prarit@redhat.com
Cc: feng.tang@intel.com
Cc: pmladek@suse.com
Cc: gnomes@lxorguk.ukuu.org.uk
Cc: linux-s390@vger.kernel.org
Cc: boris.ostrovsky@oracle.com
Cc: jgross@suse.com
Cc: pbonzini@redhat.com
Link: https://lkml.kernel.org/r/20180719205545.16512-26-pasha.tatashin@oracle.com
---
arch/x86/include/asm/tsc.h | 1 +
arch/x86/kernel/tsc.c | 54 ++++++++++++++++++++++++++++++----------------
2 files changed, 37 insertions(+), 18 deletions(-)
diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h
index c4368ff73652..88140e4f2292 100644
--- a/arch/x86/include/asm/tsc.h
+++ b/arch/x86/include/asm/tsc.h
@@ -40,6 +40,7 @@ extern int unsynchronized_tsc(void);
extern int check_tsc_unstable(void);
extern void mark_tsc_async_resets(char *reason);
extern unsigned long native_calibrate_cpu(void);
+extern unsigned long native_calibrate_cpu_early(void);
extern unsigned long native_calibrate_tsc(void);
extern unsigned long long native_sched_clock_from_tsc(u64 tsc);
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 9277ae9b68b3..60586779b02c 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -680,30 +680,17 @@ static unsigned long cpu_khz_from_cpuid(void)
return eax_base_mhz * 1000;
}
-/**
- * native_calibrate_cpu - calibrate the cpu on boot
+/*
+ * calibrate cpu using pit, hpet, and ptimer methods. They are available
+ * later in boot after acpi is initialized.
*/
-unsigned long native_calibrate_cpu(void)
+static unsigned long pit_hpet_ptimer_calibrate_cpu(void)
{
u64 tsc1, tsc2, delta, ref1, ref2;
unsigned long tsc_pit_min = ULONG_MAX, tsc_ref_min = ULONG_MAX;
- unsigned long flags, latch, ms, fast_calibrate;
+ unsigned long flags, latch, ms;
int hpet = is_hpet_enabled(), i, loopmin;
- fast_calibrate = cpu_khz_from_cpuid();
- if (fast_calibrate)
- return fast_calibrate;
-
- fast_calibrate = cpu_khz_from_msr();
- if (fast_calibrate)
- return fast_calibrate;
-
- local_irq_save(flags);
- fast_calibrate = quick_pit_calibrate();
- local_irq_restore(flags);
- if (fast_calibrate)
- return fast_calibrate;
-
/*
* Run 5 calibration loops to get the lowest frequency value
* (the best estimate). We use two different calibration modes
@@ -846,6 +833,37 @@ unsigned long native_calibrate_cpu(void)
return tsc_pit_min;
}
+/**
+ * native_calibrate_cpu_early - can calibrate the cpu early in boot
+ */
+unsigned long native_calibrate_cpu_early(void)
+{
+ unsigned long flags, fast_calibrate = cpu_khz_from_cpuid();
+
+ if (!fast_calibrate)
+ fast_calibrate = cpu_khz_from_msr();
+ if (!fast_calibrate) {
+ local_irq_save(flags);
+ fast_calibrate = quick_pit_calibrate();
+ local_irq_restore(flags);
+ }
+ return fast_calibrate;
+}
+
+
+/**
+ * native_calibrate_cpu - calibrate the cpu
+ */
+unsigned long native_calibrate_cpu(void)
+{
+ unsigned long tsc_freq = native_calibrate_cpu_early();
+
+ if (!tsc_freq)
+ tsc_freq = pit_hpet_ptimer_calibrate_cpu();
+
+ return tsc_freq;
+}
+
void recalibrate_cpu_khz(void)
{
#ifndef CONFIG_SMP
next prev parent reply other threads:[~2018-07-19 22:34 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 20:55 [PATCH v15 00/26] Early boot time stamps Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 01/26] x86/kvmclock: Remove memblock dependency Pavel Tatashin
2018-07-19 22:21 ` [tip:x86/timers] " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 02/26] x86/kvmclock: Remove page size requirement from wall_clock Pavel Tatashin
2018-07-19 22:22 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 03/26] x86/kvmclock: Decrapify kvm_register_clock() Pavel Tatashin
2018-07-19 22:23 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 04/26] x86/kvmclock: Cleanup the code Pavel Tatashin
2018-07-19 22:23 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 05/26] x86/kvmclock: Mark variables __initdata and __ro_after_init Pavel Tatashin
2018-07-19 22:24 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 06/26] x86/kvmclock: Move kvmclock vsyscall param and init to kvmclock Pavel Tatashin
2018-07-19 22:24 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 07/26] x86/kvmclock: Switch kvmclock data to a PER_CPU variable Pavel Tatashin
2018-07-19 22:25 ` [tip:x86/timers] " tip-bot for Thomas Gleixner
2018-07-19 20:55 ` [PATCH v15 08/26] x86: text_poke() may access uninitialized struct pages Pavel Tatashin
2018-07-19 22:25 ` [tip:x86/timers] x86/alternatives, jumplabel: Use text_poke_early() before mm_init() tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 09/26] x86: initialize static branching early Pavel Tatashin
2018-07-19 22:26 ` [tip:x86/timers] x86/jump_label: Initialize " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 10/26] x86/CPU: Call detect_nopl() only on the BSP Pavel Tatashin
2018-07-19 22:26 ` [tip:x86/timers] " tip-bot for Borislav Petkov
2018-07-19 20:55 ` [PATCH v15 11/26] x86/tsc: redefine notsc to behave as tsc=unstable Pavel Tatashin
2018-07-19 22:27 ` [tip:x86/timers] x86/tsc: Redefine " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 12/26] x86/xen/time: initialize pv xen time in init_hypervisor_platform Pavel Tatashin
2018-07-19 22:27 ` [tip:x86/timers] x86/xen/time: Initialize pv xen time in init_hypervisor_platform() tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 13/26] x86/xen/time: output xen sched_clock time from 0 Pavel Tatashin
2018-07-19 22:28 ` [tip:x86/timers] x86/xen/time: Output " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 14/26] s390/time: add read_persistent_wall_and_boot_offset() Pavel Tatashin
2018-07-19 22:28 ` [tip:x86/timers] s390/time: Add read_persistent_wall_and_boot_offset() tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 15/26] time: replace read_boot_clock64() with read_persistent_wall_and_boot_offset() Pavel Tatashin
2018-07-19 22:29 ` [tip:x86/timers] timekeeping: Replace " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 16/26] time: default boot time offset to local_clock() Pavel Tatashin
2018-07-19 22:29 ` [tip:x86/timers] timekeeping: Default " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 17/26] s390/time: remove read_boot_clock64() Pavel Tatashin
2018-07-19 22:30 ` [tip:x86/timers] s390/time: Remove read_boot_clock64() tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 18/26] ARM/time: remove read_boot_clock64() Pavel Tatashin
2018-07-19 22:30 ` [tip:x86/timers] ARM/time: Remove read_boot_clock64() tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 19/26] x86/tsc: calibrate tsc only once Pavel Tatashin
2018-07-19 22:31 ` [tip:x86/timers] x86/tsc: Calibrate " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 20/26] x86/tsc: initialize cyc2ns when tsc freq. is determined Pavel Tatashin
2018-07-19 22:31 ` [tip:x86/timers] x86/tsc: Initialize cyc2ns when tsc frequency " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 21/26] x86/tsc: use tsc early Pavel Tatashin
2018-07-19 22:32 ` [tip:x86/timers] x86/tsc: Use TSC as sched clock early tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 22/26] sched: move sched clock initialization and merge with generic clock Pavel Tatashin
2018-07-19 22:32 ` [tip:x86/timers] sched/clock: Move " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 23/26] sched: early boot clock Pavel Tatashin
2018-07-19 22:33 ` [tip:x86/timers] sched/clock: Enable sched clock early tip-bot for Pavel Tatashin
2018-07-24 19:52 ` Guenter Roeck
2018-07-24 20:22 ` Pavel Tatashin
2018-07-25 0:36 ` Pavel Tatashin
2018-07-25 1:24 ` Guenter Roeck
2018-07-25 2:05 ` Pavel Tatashin
2018-07-25 2:41 ` Pavel Tatashin
2018-07-30 12:36 ` Peter Zijlstra
2018-07-30 13:44 ` Pavel Tatashin
2018-07-20 8:09 ` [PATCH v15 23/26] sched: early boot clock Peter Zijlstra
2018-07-20 10:00 ` [tip:x86/timers] sched/clock: Close a hole in sched_clock_init() tip-bot for Peter Zijlstra
2018-11-06 5:42 ` [PATCH v15 23/26] sched: early boot clock Dominique Martinet
2018-11-06 11:35 ` Steven Sistare
2019-01-02 20:20 ` Salvatore Bonaccorso
2019-01-03 21:28 ` Pavel Tatashin
2019-01-03 23:43 ` Dominique Martinet
2019-01-07 18:17 ` Pavel Tatashin
2019-01-07 23:48 ` Dominique Martinet
2019-01-08 1:04 ` Pavel Tatashin
2019-01-08 1:09 ` Dominique Martinet
2019-01-26 2:04 ` Jon DeVree
2019-01-26 16:11 ` Pavel Tatashin
2019-01-04 7:30 ` [PATCH v15 23/26] sched: early boot clock (was Re: Bug#918036: linux: uptime after reboot wrong (kvm-clock related?)) Thorsten Glaser
2018-07-19 20:55 ` [PATCH v15 24/26] sched: use static key for sched_clock_running Pavel Tatashin
2018-07-19 22:33 ` [tip:x86/timers] sched/clock: Use " tip-bot for Pavel Tatashin
2018-07-19 20:55 ` [PATCH v15 25/26] x86/tsc: split native_calibrate_cpu() into early and late parts Pavel Tatashin
2018-07-19 22:34 ` tip-bot for Pavel Tatashin [this message]
2018-07-19 20:55 ` [PATCH v15 26/26] x86/tsc: use tsc_calibrate_cpu_early and pit_hpet_ptimer_calibrate_cpu Pavel Tatashin
2018-07-19 22:35 ` [tip:x86/timers] x86/tsc: Make use of tsc_calibrate_cpu_early() tip-bot for Pavel Tatashin
2018-07-19 22:34 ` [PATCH v15 00/26] Early boot time stamps Thomas Gleixner
[not found] <154644530361.2390.18185252504260044930.reportbug@ci-busyapps.lan.tarent.de>
[not found] ` <20190102163939.GB13145@eldamar.local>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-03821f451d2d2d7599061244734245be139014ea@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome