mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Wang Nan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, daniel@iogearbox.net,
	masami.hiramatsu.pt@hitachi.com, hekuang@huawei.com,
	jolsa@kernel.org, wangnan0@huawei.com, brendan.d.gregg@gmail.com,
	namhyung@kernel.org, a.p.zijlstra@chello.nl, acme@redhat.com,
	dsahern@gmail.com, xiakaixu@huawei.com, hpa@zytor.com,
	tglx@linutronix.de, mingo@kernel.org, ast@plumgrid.com,
	lizefan@huawei.com
Subject: [tip:perf/core] tracing, perf: Implement BPF programs attached to uprobes
Date: Fri, 7 Aug 2015 00:16:13 -0700	[thread overview]
Message-ID: <tip-04a22fae4cbc1f7d3f7471e9b36359f98bd3f043@git.kernel.org> (raw)
In-Reply-To: <1435716878-189507-3-git-send-email-wangnan0@huawei.com>

Commit-ID:  04a22fae4cbc1f7d3f7471e9b36359f98bd3f043
Gitweb:     http://git.kernel.org/tip/04a22fae4cbc1f7d3f7471e9b36359f98bd3f043
Author:     Wang Nan <wangnan0@huawei.com>
AuthorDate: Wed, 1 Jul 2015 02:13:50 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 6 Aug 2015 15:29:14 -0300

tracing, perf: Implement BPF programs attached to uprobes

By copying BPF related operation to uprobe processing path, this patch
allow users attach BPF programs to uprobes like what they are already
doing on kprobes.

After this patch, users are allowed to use PERF_EVENT_IOC_SET_BPF on a
uprobe perf event. Which make it possible to profile user space programs
and kernel events together using BPF.

Because of this patch, CONFIG_BPF_EVENTS should be selected by
CONFIG_UPROBE_EVENT to ensure trace_call_bpf() is compiled even if
KPROBE_EVENT is not set.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Ahern <dsahern@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kaixu Xia <xiakaixu@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1435716878-189507-3-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 include/linux/trace_events.h | 5 +++++
 kernel/events/core.c         | 4 ++--
 kernel/trace/Kconfig         | 2 +-
 kernel/trace/trace_uprobe.c  | 5 +++++
 4 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 180dbf8..ed27917 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -243,6 +243,7 @@ enum {
 	TRACE_EVENT_FL_USE_CALL_FILTER_BIT,
 	TRACE_EVENT_FL_TRACEPOINT_BIT,
 	TRACE_EVENT_FL_KPROBE_BIT,
+	TRACE_EVENT_FL_UPROBE_BIT,
 };
 
 /*
@@ -257,6 +258,7 @@ enum {
  *  USE_CALL_FILTER - For trace internal events, don't use file filter
  *  TRACEPOINT    - Event is a tracepoint
  *  KPROBE        - Event is a kprobe
+ *  UPROBE        - Event is a uprobe
  */
 enum {
 	TRACE_EVENT_FL_FILTERED		= (1 << TRACE_EVENT_FL_FILTERED_BIT),
@@ -267,8 +269,11 @@ enum {
 	TRACE_EVENT_FL_USE_CALL_FILTER	= (1 << TRACE_EVENT_FL_USE_CALL_FILTER_BIT),
 	TRACE_EVENT_FL_TRACEPOINT	= (1 << TRACE_EVENT_FL_TRACEPOINT_BIT),
 	TRACE_EVENT_FL_KPROBE		= (1 << TRACE_EVENT_FL_KPROBE_BIT),
+	TRACE_EVENT_FL_UPROBE		= (1 << TRACE_EVENT_FL_UPROBE_BIT),
 };
 
+#define TRACE_EVENT_FL_UKPROBE (TRACE_EVENT_FL_KPROBE | TRACE_EVENT_FL_UPROBE)
+
 struct trace_event_call {
 	struct list_head	list;
 	struct trace_event_class *class;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index bdea129..77f9e5d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6846,8 +6846,8 @@ static int perf_event_set_bpf_prog(struct perf_event *event, u32 prog_fd)
 	if (event->tp_event->prog)
 		return -EEXIST;
 
-	if (!(event->tp_event->flags & TRACE_EVENT_FL_KPROBE))
-		/* bpf programs can only be attached to kprobes */
+	if (!(event->tp_event->flags & TRACE_EVENT_FL_UKPROBE))
+		/* bpf programs can only be attached to u/kprobes */
 		return -EINVAL;
 
 	prog = bpf_prog_get(prog_fd);
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 3b9a48a..1153c43 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -434,7 +434,7 @@ config UPROBE_EVENT
 
 config BPF_EVENTS
 	depends on BPF_SYSCALL
-	depends on KPROBE_EVENT
+	depends on KPROBE_EVENT || UPROBE_EVENT
 	bool
 	default y
 	help
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index aa1ea7b..f97479f 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -1095,11 +1095,15 @@ static void __uprobe_perf_func(struct trace_uprobe *tu,
 {
 	struct trace_event_call *call = &tu->tp.call;
 	struct uprobe_trace_entry_head *entry;
+	struct bpf_prog *prog = call->prog;
 	struct hlist_head *head;
 	void *data;
 	int size, esize;
 	int rctx;
 
+	if (prog && !trace_call_bpf(prog, regs))
+		return;
+
 	esize = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
 
 	size = esize + tu->tp.size + dsize;
@@ -1289,6 +1293,7 @@ static int register_uprobe_event(struct trace_uprobe *tu)
 		return -ENODEV;
 	}
 
+	call->flags = TRACE_EVENT_FL_UPROBE;
 	call->class->reg = trace_uprobe_register;
 	call->data = tu;
 	ret = trace_add_event_call(call);

  reply	other threads:[~2015-08-07  7:16 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  2:13 [RFC PATCH v10 00/50] perf tools: filtering events using eBPF programs Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 01/50] bpf: Use correct #ifdef controller for trace_call_bpf() Wang Nan
2015-08-07  7:15   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 02/50] tracing, perf: Implement BPF programs attached to uprobes Wang Nan
2015-08-07  7:16   ` tip-bot for Wang Nan [this message]
2015-07-01  2:13 ` [RFC PATCH v10 03/50] bpf tools: Introduce 'bpf' library and add bpf feature check Wang Nan
2015-08-08  8:09   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 04/50] bpf tools: Allow caller to set printing function Wang Nan
2015-08-08  8:09   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 05/50] bpf tools: Open eBPF object file and do basic validation Wang Nan
2015-08-08  8:10   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 06/50] bpf tools: Read eBPF object from buffer Wang Nan
2015-08-08  8:10   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 07/50] bpf tools: Check endianness and make libbpf fail early Wang Nan
2015-08-08  8:10   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 08/50] bpf tools: Iterate over ELF sections to collect information Wang Nan
2015-08-08  8:11   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 09/50] bpf tools: Collect version and license from ELF sections Wang Nan
2015-08-08  8:11   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 10/50] bpf tools: Collect map definitions from 'maps' section Wang Nan
2015-08-08  8:11   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:13 ` [RFC PATCH v10 11/50] bpf tools: Collect symbol table from SHT_SYMTAB section Wang Nan
2015-07-07 15:10   ` Arnaldo Carvalho de Melo
2015-08-08  8:12   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 12/50] bpf tools: Collect eBPF programs from their own sections Wang Nan
2015-07-07 15:17   ` Arnaldo Carvalho de Melo
2015-08-08  8:12   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 13/50] bpf tools: Collect relocation sections from SHT_REL sections Wang Nan
2015-08-08  8:12   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 14/50] bpf tools: Record map accessing instructions for each program Wang Nan
2015-08-08  8:13   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 15/50] bpf tools: Add bpf.c/h for common bpf operations Wang Nan
2015-08-08  8:13   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 16/50] bpf tools: Create eBPF maps defined in an object file Wang Nan
2015-08-08  8:14   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 17/50] bpf tools: Relocate eBPF programs Wang Nan
2015-08-08  8:14   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 18/50] bpf tools: Introduce bpf_load_program() to bpf.c Wang Nan
2015-08-08  8:14   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 19/50] bpf tools: Load eBPF programs in object files into kernel Wang Nan
2015-08-08  8:15   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 20/50] bpf tools: Introduce accessors for struct bpf_program Wang Nan
2015-07-07 19:37   ` Arnaldo Carvalho de Melo
2015-08-08  8:15   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 21/50] bpf tools: Introduce accessors for struct bpf_object Wang Nan
2015-07-07 19:39   ` Arnaldo Carvalho de Melo
2015-07-01  2:14 ` [RFC PATCH v10 22/50] bpf tools: Link all bpf objects onto a list Wang Nan
2015-07-07 19:47   ` Arnaldo Carvalho de Melo
2015-08-08  8:15   ` [tip:perf/core] " tip-bot for Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 23/50] perf tools: Make perf depend on libbpf Wang Nan
2015-07-07 19:54   ` Arnaldo Carvalho de Melo
2015-07-07 20:16     ` Arnaldo Carvalho de Melo
2015-07-08  2:03       ` Alexei Starovoitov
2015-07-08 13:03         ` Arnaldo Carvalho de Melo
2015-07-08 11:45       ` Wangnan (F)
2015-07-08 13:02         ` Arnaldo Carvalho de Melo
2015-07-01  2:14 ` [RFC PATCH v10 24/50] perf tools: Introduce llvm config options Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 25/50] perf tools: Call clang to compile C source to object code Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 26/50] perf tests: Add LLVM test for eBPF on-the-fly compiling Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 27/50] perf tools: Auto detecting kernel build directory Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 28/50] perf tools: Auto detecting kernel include options Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 29/50] perf record: Enable passing bpf object file to --event Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 30/50] perf record: Compile scriptlets if pass '.c' " Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 31/50] perf tools: Parse probe points of eBPF programs during preparation Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 32/50] perf probe: Attach trace_probe_event with perf_probe_event Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 33/50] perf record: Probe at kprobe points Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 34/50] perf record: Load all eBPF object into kernel Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 35/50] perf tools: Add bpf_fd field to evsel and config it Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 36/50] perf tools: Attach eBPF program to perf event Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 37/50] perf tools: Suppress probing messages when probing by BPF loading Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 38/50] perf record: Add clang options for compiling BPF scripts Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 39/50] bpf tools: Load a program with different instance using preprocessor Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 40/50] perf tools: Fix probe-event.h include Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 41/50] perf probe: Reset tev->args and tev->nargs when failure Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 42/50] perf tools: Move linux/filter.h to tools/include Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 43/50] perf tools: Add BPF_PROLOGUE config options for further patches Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 44/50] perf tools: Introduce arch_get_reg_info() for x86 Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 45/50] perf tools: Add prologue for BPF programs for fetching arguments Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 46/50] perf tools: Generate prologue for BPF programs Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 47/50] perf tools: Use same BPF program if arguments are identical Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 48/50] perf record: Support custom vmlinux path Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 49/50] perf probe: Init symbol as kprobe if any event is kprobe Wang Nan
2015-07-01  2:14 ` [RFC PATCH v10 50/50] perf tools: Support attach BPF program on uprobe events Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-04a22fae4cbc1f7d3f7471e9b36359f98bd3f043@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=ast@plumgrid.com \
    --cc=brendan.d.gregg@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    --cc=xiakaixu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome