From: "tip-bot for Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:core/rcu] rcu: Make lockdep_rcu_dereference() message less alarmist
Date: Fri, 26 Feb 2010 09:29:23 GMT [thread overview]
Message-ID: <tip-056ba4a9bea5f32781a36b797c562fb731e5eaa6@git.kernel.org> (raw)
In-Reply-To: <1267135607-7056-1-git-send-email-paulmck@linux.vnet.ibm.com>
Commit-ID: 056ba4a9bea5f32781a36b797c562fb731e5eaa6
Gitweb: http://git.kernel.org/tip/056ba4a9bea5f32781a36b797c562fb731e5eaa6
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
AuthorDate: Thu, 25 Feb 2010 14:06:46 -0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 26 Feb 2010 08:20:46 +0100
rcu: Make lockdep_rcu_dereference() message less alarmist
Change from "unsafe" to "suspicious", given that there will be
false alarms.
Suggested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: mathieu.desnoyers@polymtl.ca
Cc: josh@joshtriplett.org
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
Cc: Valdis.Kletnieks@vt.edu
Cc: dhowells@redhat.com
LKML-Reference: <1267135607-7056-1-git-send-email-paulmck@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/lockdep.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 672c436..0c30d04 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3816,9 +3816,9 @@ void lockdep_rcu_dereference(const char *file, const int line)
if (!debug_locks_off())
return;
- printk("\n==============================================\n");
- printk( "[ BUG: Unsafe rcu_dereference_check() usage! ]\n");
- printk( "----------------------------------------------\n");
+ printk("\n===================================================\n");
+ printk( "[ INFO: suspicious rcu_dereference_check() usage. ]\n");
+ printk( "---------------------------------------------------\n");
printk("%s:%d invoked rcu_dereference_check() without protection!\n",
file, line);
printk("\nother info that might help us debug this:\n\n");
next prev parent reply other threads:[~2010-02-26 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 22:06 [PATCH tip/core/rcu 0/2] rcu: fixes for RCU lockdep Paul E. McKenney
2010-02-25 22:06 ` [PATCH tip/core/rcu 1/2] rcu: make lockdep_rcu_dereference() message less alarmist Paul E. McKenney
2010-02-26 9:29 ` tip-bot for Paul E. McKenney [this message]
2010-02-25 22:06 ` [PATCH tip/core/rcu 2/2] rcu: make rcu_read_lock_sched_held() take boot time into account Paul E. McKenney
2010-02-26 9:29 ` [tip:core/rcu] rcu: Make " tip-bot for Paul E. McKenney
2010-02-26 3:02 ` [PATCH tip/core/rcu] rcu: export rcu_scheduler_active Paul E. McKenney
2010-02-26 9:29 ` [tip:core/rcu] rcu: Export rcu_scheduler_active tip-bot for Paul E. McKenney
2010-02-26 11:50 ` [PATCH tip/core/rcu 0/2] rcu: fixes for RCU lockdep Ingo Molnar
2010-02-26 13:19 ` Ingo Molnar
2010-02-26 14:46 ` Ingo Molnar
2010-02-26 17:02 ` Paul E. McKenney
2010-02-26 17:42 ` Paul E. McKenney
2010-02-27 9:51 ` Ingo Molnar
2010-02-27 12:59 ` Ingo Molnar
2010-02-27 22:48 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-056ba4a9bea5f32781a36b797c562fb731e5eaa6@git.kernel.org \
--to=paulmck@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome