From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106AbbLDMEq (ORCPT ); Fri, 4 Dec 2015 07:04:46 -0500 Received: from terminus.zytor.com ([198.137.202.10]:60522 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbbLDMEp (ORCPT ); Fri, 4 Dec 2015 07:04:45 -0500 Date: Fri, 4 Dec 2015 04:03:33 -0800 From: tip-bot for Borislav Petkov Message-ID: Cc: keescook@chromium.org, paulmck@linux.vnet.ibm.com, peterz@infradead.org, arjan@linux.intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, dvlasenk@redhat.com, brgerst@gmail.com, luto@amacapital.net, akpm@linux-foundation.org, torvalds@linux-foundation.org, bp@alien8.de, bp@suse.de Reply-To: mingo@kernel.org, brgerst@gmail.com, dvlasenk@redhat.com, hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, luto@amacapital.net, akpm@linux-foundation.org, bp@suse.de, bp@alien8.de, torvalds@linux-foundation.org, keescook@chromium.org, peterz@infradead.org, paulmck@linux.vnet.ibm.com, arjan@linux.intel.com In-Reply-To: <1448885579-32506-1-git-send-email-bp@alien8.de> References: <1448885579-32506-1-git-send-email-bp@alien8.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/mm/ptdump: Make (debugfs)/ kernel_page_tables read-only Git-Commit-ID: 071ac0c4e8e90d5de05f0779b03ae69ce84820d5 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 071ac0c4e8e90d5de05f0779b03ae69ce84820d5 Gitweb: http://git.kernel.org/tip/071ac0c4e8e90d5de05f0779b03ae69ce84820d5 Author: Borislav Petkov AuthorDate: Mon, 30 Nov 2015 13:12:59 +0100 Committer: Ingo Molnar CommitDate: Fri, 4 Dec 2015 12:55:01 +0100 x86/mm/ptdump: Make (debugfs)/kernel_page_tables read-only File should be created with S_IRUSR and not with S_IWUSR too because writing to it doesn't make any sense. I mean, we don't have a ->write method anyway but let's have the permissions correct too. Signed-off-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Arjan van de Ven Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Kees Cook Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1448885579-32506-1-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar --- arch/x86/mm/debug_pagetables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/debug_pagetables.c b/arch/x86/mm/debug_pagetables.c index b35ee86..bfcffdf 100644 --- a/arch/x86/mm/debug_pagetables.c +++ b/arch/x86/mm/debug_pagetables.c @@ -26,7 +26,7 @@ static struct dentry *pe; static int __init pt_dump_debug_init(void) { - pe = debugfs_create_file("kernel_page_tables", 0600, NULL, NULL, + pe = debugfs_create_file("kernel_page_tables", S_IRUSR, NULL, NULL, &ptdump_fops); if (!pe) return -ENOMEM;