From: tip-bot for Avi Kivity <avi@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@elte.hu,
avi@redhat.com
Subject: [tip:perf/core] x86, perf: Add constraints for architectural PMU
Date: Fri, 1 Jul 2011 15:24:48 GMT [thread overview]
Message-ID: <tip-0af3ac1fdb9d5c297b4b07c9e0172531d42b6716@git.kernel.org> (raw)
In-Reply-To: <1309362157-6596-3-git-send-email-avi@redhat.com>
Commit-ID: 0af3ac1fdb9d5c297b4b07c9e0172531d42b6716
Gitweb: http://git.kernel.org/tip/0af3ac1fdb9d5c297b4b07c9e0172531d42b6716
Author: Avi Kivity <avi@redhat.com>
AuthorDate: Wed, 29 Jun 2011 18:42:36 +0300
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 1 Jul 2011 11:06:39 +0200
x86, perf: Add constraints for architectural PMU
The v1 PMU does not have any fixed counters. Using the v2 constraints,
which do have fixed counters, causes an additional choice to be present
in the weight calculation, but not when actually scheduling the event,
leading to an event being not scheduled at all.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1309362157-6596-3-git-send-email-avi@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/perf_event_intel.c | 23 ++++++++++++++++++-----
1 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index bf6f92f..45fbb8f 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -112,6 +112,11 @@ static struct extra_reg intel_westmere_extra_regs[] __read_mostly =
EVENT_EXTRA_END
};
+static struct event_constraint intel_v1_event_constraints[] __read_mostly =
+{
+ EVENT_CONSTRAINT_END
+};
+
static struct event_constraint intel_gen_event_constraints[] __read_mostly =
{
FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
@@ -1606,11 +1611,19 @@ static __init int intel_pmu_init(void)
break;
default:
- /*
- * default constraints for v2 and up
- */
- x86_pmu.event_constraints = intel_gen_event_constraints;
- pr_cont("generic architected perfmon, ");
+ switch (x86_pmu.version) {
+ case 1:
+ x86_pmu.event_constraints = intel_v1_event_constraints;
+ pr_cont("generic architected perfmon v1, ");
+ break;
+ default:
+ /*
+ * default constraints for v2 and up
+ */
+ x86_pmu.event_constraints = intel_gen_event_constraints;
+ pr_cont("generic architected perfmon, ");
+ break;
+ }
}
return 0;
}
next prev parent reply other threads:[~2011-07-01 15:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 15:42 [PATCH 0/3] Preparatory perf patches for KVM PMU support Avi Kivity
2011-06-29 15:42 ` [PATCH 1/3] perf: add context field to perf_event Avi Kivity
2011-06-29 16:08 ` Frederic Weisbecker
2011-06-29 16:25 ` Avi Kivity
2011-06-29 16:27 ` Will Deacon
2011-07-04 13:58 ` Frederic Weisbecker
2011-07-04 14:10 ` Avi Kivity
2011-07-04 14:36 ` Frederic Weisbecker
2011-07-11 21:07 ` Will Deacon
2011-07-12 7:20 ` Avi Kivity
2011-07-12 8:38 ` Peter Zijlstra
2011-07-12 9:08 ` Avi Kivity
2011-07-12 9:14 ` Peter Zijlstra
2011-07-12 9:16 ` Avi Kivity
2011-07-12 9:18 ` Peter Zijlstra
2011-07-12 9:27 ` Avi Kivity
2011-07-12 9:31 ` Peter Zijlstra
2011-07-12 9:36 ` Avi Kivity
2011-07-12 9:42 ` Will Deacon
2011-07-12 9:41 ` Joerg Roedel
2011-07-12 9:44 ` Avi Kivity
2011-07-12 9:48 ` Joerg Roedel
2011-07-12 9:55 ` Avi Kivity
2011-07-12 10:03 ` Joerg Roedel
2011-07-12 10:07 ` Avi Kivity
2011-07-12 10:24 ` Joerg Roedel
2011-07-12 10:36 ` Avi Kivity
2011-07-21 15:32 ` Will Deacon
2011-07-21 15:36 ` Avi Kivity
2011-07-21 15:46 ` Will Deacon
2011-07-21 15:59 ` Avi Kivity
2011-07-21 16:37 ` Will Deacon
2011-07-05 14:30 ` Will Deacon
2011-07-05 14:34 ` Frederic Weisbecker
2011-07-01 15:24 ` [tip:perf/core] perf: Add " tip-bot for Avi Kivity
2011-06-29 15:42 ` [PATCH 2/3] x86, perf: add constraints for architectural PMU v1 Avi Kivity
2011-07-01 15:24 ` tip-bot for Avi Kivity [this message]
2011-06-29 15:42 ` [PATCH 3/3] perf: export perf_event_refresh() to modules Avi Kivity
2011-07-01 15:25 ` [tip:perf/core] " tip-bot for Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0af3ac1fdb9d5c297b4b07c9e0172531d42b6716@git.kernel.org \
--to=avi@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome