From: tip-bot for Daniel Bristot de Oliveira <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: rostedt@goodmis.org, mhiramat@kernel.org, tglx@linutronix.de,
crecklin@redhat.com, gregkh@linuxfoundation.org,
jbaron@akamai.com, bp@alien8.de, peterz@infradead.org,
jkosina@suse.cz, linux-kernel@vger.kernel.org, mingo@kernel.org,
mtosatti@redhat.com, torvalds@linux-foundation.org,
williams@redhat.com, hpa@zytor.com, jpoimboe@redhat.com,
bristot@redhat.com, swood@redhat.com
Subject: [tip:locking/core] jump_label: Sort entries of the same key by the code
Date: Mon, 17 Jun 2019 07:14:30 -0700 [thread overview]
Message-ID: <tip-0f133021bd82548a33580bfb7b055e8857f46c2a@git.kernel.org> (raw)
In-Reply-To: <f57ae83e0592418ba269866bb7ade570fc8632e0.1560325897.git.bristot@redhat.com>
Commit-ID: 0f133021bd82548a33580bfb7b055e8857f46c2a
Gitweb: https://git.kernel.org/tip/0f133021bd82548a33580bfb7b055e8857f46c2a
Author: Daniel Bristot de Oliveira <bristot@redhat.com>
AuthorDate: Wed, 12 Jun 2019 11:57:28 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 17 Jun 2019 12:09:21 +0200
jump_label: Sort entries of the same key by the code
In the batching mode, all the entries of a given key are updated at once.
During the update of a key, a hit in the int3 handler will check if the
hitting code address belongs to one of these keys.
To optimize the search of a given code in the vector of entries being
updated, a binary search is used. The binary search relies on the order
of the entries of a key by its code. Hence the keys need to be sorted
by the code too, so sort the entries of a given key by the code.
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Chris von Recklinghausen <crecklin@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jason Baron <jbaron@akamai.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Scott Wood <swood@redhat.com>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/f57ae83e0592418ba269866bb7ade570fc8632e0.1560325897.git.bristot@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/jump_label.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/kernel/jump_label.c b/kernel/jump_label.c
index 24f0d3b1526b..ca00ac10d9b9 100644
--- a/kernel/jump_label.c
+++ b/kernel/jump_label.c
@@ -37,12 +37,26 @@ static int jump_label_cmp(const void *a, const void *b)
const struct jump_entry *jea = a;
const struct jump_entry *jeb = b;
+ /*
+ * Entrires are sorted by key.
+ */
if (jump_entry_key(jea) < jump_entry_key(jeb))
return -1;
if (jump_entry_key(jea) > jump_entry_key(jeb))
return 1;
+ /*
+ * In the batching mode, entries should also be sorted by the code
+ * inside the already sorted list of entries, enabling a bsearch in
+ * the vector.
+ */
+ if (jump_entry_code(jea) < jump_entry_code(jeb))
+ return -1;
+
+ if (jump_entry_code(jea) > jump_entry_code(jeb))
+ return 1;
+
return 0;
}
next prev parent reply other threads:[~2019-06-17 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:57 [PATCH V6 0/6] x86/jump_label: Bound IPIs sent when updating a static key Daniel Bristot de Oliveira
2019-06-12 9:57 ` [PATCH V6 1/6] jump_label: Add a jump_label_can_update() helper Daniel Bristot de Oliveira
2019-06-17 14:13 ` [tip:locking/core] " tip-bot for Daniel Bristot de Oliveira
2019-06-12 9:57 ` [PATCH V6 2/6] x86/jump_label: Add a __jump_label_set_jump_code() helper Daniel Bristot de Oliveira
2019-06-17 14:13 ` [tip:locking/core] " tip-bot for Daniel Bristot de Oliveira
2019-06-12 9:57 ` [PATCH V6 3/6] jump_label: Sort entries of the same key by the code Daniel Bristot de Oliveira
2019-06-17 14:14 ` tip-bot for Daniel Bristot de Oliveira [this message]
2019-06-12 9:57 ` [PATCH V6 4/6] x86/alternative: Batch of patch operations Daniel Bristot de Oliveira
2019-06-12 14:52 ` Peter Zijlstra
2019-06-12 16:33 ` Daniel Bristot de Oliveira
2019-06-17 14:15 ` [tip:locking/core] " tip-bot for Daniel Bristot de Oliveira
2019-06-12 9:57 ` [PATCH V6 5/6] jump_label: Batch updates if arch supports it Daniel Bristot de Oliveira
2019-06-17 14:15 ` [tip:locking/core] " tip-bot for Daniel Bristot de Oliveira
2019-06-12 9:57 ` [PATCH V6 6/6] x86/jump_label: Batch jump label updates Daniel Bristot de Oliveira
2019-06-17 14:16 ` [tip:locking/core] " tip-bot for Daniel Bristot de Oliveira
2019-06-12 17:07 ` [PATCH V6 0/6] x86/jump_label: Bound IPIs sent when updating a static key Peter Zijlstra
2019-06-13 8:08 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-0f133021bd82548a33580bfb7b055e8857f46c2a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=crecklin@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome