From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762149AbcALK0K (ORCPT ); Tue, 12 Jan 2016 05:26:10 -0500 Received: from terminus.zytor.com ([198.137.202.10]:56805 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbcALK0D (ORCPT ); Tue, 12 Jan 2016 05:26:03 -0500 Date: Tue, 12 Jan 2016 02:25:04 -0800 From: tip-bot for Andy Lutomirski Message-ID: Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, bp@alien8.de, mingo@kernel.org, brgerst@gmail.com, luto@kernel.org, luto@amacapital.net, hpa@zytor.com, peterz@infradead.org, torvalds@linux-foundation.org, shuahkh@osg.samsung.com, dvlasenk@redhat.com Reply-To: luto@kernel.org, brgerst@gmail.com, mingo@kernel.org, bp@alien8.de, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, luto@amacapital.net, peterz@infradead.org, dvlasenk@redhat.com, shuahkh@osg.samsung.com, torvalds@linux-foundation.org In-Reply-To: <231591d9122d282402d8f53175134f8db5b3bc73.1452561752.git.luto@kernel.org> References: <231591d9122d282402d8f53175134f8db5b3bc73.1452561752.git.luto@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] selftests/x86: Disable the ldt_gdt_64 test for now Git-Commit-ID: 0f672809f91abd0aee01624ccad9199a62e3da7a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0f672809f91abd0aee01624ccad9199a62e3da7a Gitweb: http://git.kernel.org/tip/0f672809f91abd0aee01624ccad9199a62e3da7a Author: Andy Lutomirski AuthorDate: Mon, 11 Jan 2016 17:23:32 -0800 Committer: Ingo Molnar CommitDate: Tue, 12 Jan 2016 11:09:26 +0100 selftests/x86: Disable the ldt_gdt_64 test for now ldt_gdt.c relies on cross-cpu invalidation of SS to do one of its tests. On 32-bit builds, this works fine, but on 64-bit builds, it only works if the kernel has proper SS sigcontext handling for 64-bit user programs. Since the SS fixes are currently reverted, restrict the test case to 32 bits for now. In principle, I could change the test to use a different segment register, but it would be messy: CS can't point to the LDT for 64-bit code, and the other registers don't result in immediate faults because they aren't reloaded on kernel -> user transitions. When we fix sigcontext (in 4.6?), we can revert this. Signed-off-by: Andy Lutomirski Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Shuah Khan Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/231591d9122d282402d8f53175134f8db5b3bc73.1452561752.git.luto@kernel.org Signed-off-by: Ingo Molnar --- tools/testing/selftests/x86/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index eabcff4..398bb0e 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -4,9 +4,10 @@ include ../lib.mk .PHONY: all all_32 all_64 warn_32bit_failure clean -TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs ldt_gdt syscall_nt ptrace_syscall +TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt ptrace_syscall TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault sigreturn test_syscall_vdso unwind_vdso \ - test_FCMOV test_FCOMI test_FISTTP + test_FCMOV test_FCOMI test_FISTTP \ + ldt_gdt TARGETS_C_32BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_32BIT_ONLY) BINARIES_32 := $(TARGETS_C_32BIT_ALL:%=%_32)