From: tip-bot for Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: mathieu.desnoyers@polymtl.ca, linux-kernel@vger.kernel.org,
hpa@zytor.com, mingo@redhat.com, rusty@rustcorp.com.au,
torvalds@linux-foundation.org, fweisbec@gmail.com,
rostedt@goodmis.org, hch@lst.de, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:tracing/urgent] modules, tracing: Remove stale struct marker signature from module_layout()
Date: Wed, 23 Sep 2009 09:04:34 GMT [thread overview]
Message-ID: <tip-115e8a288252ef748f34f8b7c1115c563d702eda@git.kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.01.0909210908020.4950@localhost.localdomain>
Commit-ID: 115e8a288252ef748f34f8b7c1115c563d702eda
Gitweb: http://git.kernel.org/tip/115e8a288252ef748f34f8b7c1115c563d702eda
Author: Ingo Molnar <mingo@elte.hu>
AuthorDate: Mon, 21 Sep 2009 18:22:11 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 23 Sep 2009 10:34:21 +0200
modules, tracing: Remove stale struct marker signature from module_layout()
Linus reported this new build warning:
kernel/module.c:2951: warning: ?struct marker? declared inside parameter list
kernel/module.c:2951: warning: its scope is only this definition or declaration, which is probably not what you want
Caused by:
fc53776: tracing: Remove markers
module_layout() is an artificial symbol with 'significant' symbols
listed in its argument list so that it gets a proper argument types
signature that modversions can pick up to decide whether a
module is version-compatible or not. If these dont match then we
wont even look at a module.
Remove the stale marker symbol.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference: <alpine.LFD.2.01.0909210908020.4950@localhost.localdomain>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/module.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index b6ee424..392eb3d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2947,7 +2947,6 @@ void module_layout(struct module *mod,
struct modversion_info *ver,
struct kernel_param *kp,
struct kernel_symbol *ks,
- struct marker *marker,
struct tracepoint *tp)
{
}
prev parent reply other threads:[~2009-09-23 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 13:02 [GIT PULL] tracing fixes Ingo Molnar
2009-09-21 16:08 ` Linus Torvalds
2009-09-21 16:22 ` Ingo Molnar
2009-09-26 16:10 ` Christoph Hellwig
2009-10-01 19:02 ` Ingo Molnar
2009-09-23 9:04 ` tip-bot for Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-115e8a288252ef748f34f8b7c1115c563d702eda@git.kernel.org \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome