mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Thomas Renninger <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	stable@kernel.org, trenn@suse.de, tglx@linutronix.de, bp@suse.de
Subject: [tip:x86/urgent] x86/microcode/amd: Tone down printk(), don' t treat a missing firmware file as an error
Date: Tue, 12 Nov 2013 13:58:00 -0800	[thread overview]
Message-ID: <tip-11f918d3e2d3861b6931e97b3aa778e4984935aa@git.kernel.org> (raw)
In-Reply-To: <1384274383-43510-1-git-send-email-trenn@suse.de>

Commit-ID:  11f918d3e2d3861b6931e97b3aa778e4984935aa
Gitweb:     http://git.kernel.org/tip/11f918d3e2d3861b6931e97b3aa778e4984935aa
Author:     Thomas Renninger <trenn@suse.de>
AuthorDate: Tue, 12 Nov 2013 17:39:43 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 12 Nov 2013 22:03:49 +0100

x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error

Do it the same way as done in microcode_intel.c: use pr_debug()
for missing firmware files.

There seem to be CPUs out there for which no microcode update
has been submitted to kernel-firmware repo yet resulting in
scary sounding error messages in dmesg:

  microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin

Signed-off-by: Thomas Renninger <trenn@suse.de>
Acked-by: Borislav Petkov <bp@suse.de>
Cc: <stable@kernel.org>
Link: http://lkml.kernel.org/r/1384274383-43510-1-git-send-email-trenn@suse.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/microcode_amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index af99f71..c3d4cc9 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -431,7 +431,7 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device,
 		snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
 
 	if (request_firmware(&fw, (const char *)fw_name, device)) {
-		pr_err("failed to load file %s\n", fw_name);
+		pr_debug("failed to load file %s\n", fw_name);
 		goto out;
 	}
 

       reply	other threads:[~2013-11-12 21:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1384274383-43510-1-git-send-email-trenn@suse.de>
2013-11-12 21:58 ` tip-bot for Thomas Renninger [this message]
2013-11-12 22:45   ` Borislav Petkov
2013-11-12 23:00     ` Ingo Molnar
2013-11-13  2:12       ` H. Peter Anvin
2013-11-13  3:08         ` Ingo Molnar
2013-11-12 23:01     ` Borislav Petkov
2013-11-12 23:10       ` Ingo Molnar
2013-11-12 23:19         ` Borislav Petkov
2013-11-13  1:09         ` Thomas Renninger
2013-11-13  1:39           ` Ingo Molnar
2013-11-13  2:11         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-11f918d3e2d3861b6931e97b3aa778e4984935aa@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome