From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932707AbcHXNqD (ORCPT ); Wed, 24 Aug 2016 09:46:03 -0400 Received: from terminus.zytor.com ([198.137.202.10]:49916 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756058AbcHXNpd (ORCPT ); Wed, 24 Aug 2016 09:45:33 -0400 Date: Wed, 24 Aug 2016 06:06:28 -0700 From: tip-bot for Josh Poimboeuf Message-ID: Cc: peterz@infradead.org, hpa@zytor.com, luto@amacapital.net, dvlasenk@redhat.com, torvalds@linux-foundation.org, nilayvaish@gmail.com, bp@alien8.de, keescook@chromium.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, byungchul.park@lge.com, jpoimboe@redhat.com, fweisbec@gmail.com, tglx@linutronix.de, brgerst@gmail.com, mingo@kernel.org, luto@kernel.org Reply-To: nilayvaish@gmail.com, bp@alien8.de, linux-kernel@vger.kernel.org, keescook@chromium.org, peterz@infradead.org, hpa@zytor.com, luto@amacapital.net, dvlasenk@redhat.com, torvalds@linux-foundation.org, jpoimboe@redhat.com, fweisbec@gmail.com, tglx@linutronix.de, brgerst@gmail.com, mingo@kernel.org, luto@kernel.org, rostedt@goodmis.org, byungchul.park@lge.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/dumpstack/ftrace: Don't print unreliable addresses in print_context_stack_bp() Git-Commit-ID: 13e25bab7e51bdd4ba7df1ef2388961294bb565e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 13e25bab7e51bdd4ba7df1ef2388961294bb565e Gitweb: http://git.kernel.org/tip/13e25bab7e51bdd4ba7df1ef2388961294bb565e Author: Josh Poimboeuf AuthorDate: Fri, 19 Aug 2016 06:53:02 -0500 Committer: Ingo Molnar CommitDate: Wed, 24 Aug 2016 12:15:15 +0200 x86/dumpstack/ftrace: Don't print unreliable addresses in print_context_stack_bp() When function graph tracing is enabled, print_context_stack_bp() can report return_to_handler() as an unreliable address, which is confusing and misleading: return_to_handler() is really only useful as a hint for debugging, whereas print_context_stack_bp() users only care about the actual 'reliable' call path. Signed-off-by: Josh Poimboeuf Acked-by: Steven Rostedt Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Byungchul Park Cc: Denys Vlasenko Cc: Frederic Weisbecker Cc: H. Peter Anvin Cc: Kees Cook Cc: Linus Torvalds Cc: Nilay Vaish Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/c51aef578d8027791b38d2ad9bac0c7f499fde91.1471607358.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/dumpstack.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 6aad8d4..01072e9 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -126,8 +126,6 @@ print_context_stack_bp(struct task_struct *task, break; real_addr = ftrace_graph_ret_addr(task, graph, addr, retp); - if (real_addr != addr && ops->address(data, addr, 0)) - break; if (ops->address(data, real_addr, 1)) break;