From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbcCKJNR (ORCPT ); Fri, 11 Mar 2016 04:13:17 -0500 Received: from torg.zytor.com ([198.137.202.12]:34070 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753035AbcCKJNB (ORCPT ); Fri, 11 Mar 2016 04:13:01 -0500 Date: Fri, 11 Mar 2016 01:12:36 -0800 From: tip-bot for Dan Carpenter Message-ID: Cc: jason@lakedaemon.net, hpa@zytor.com, linux-kernel@vger.kernel.org, tsahee@annapurnalabs.com, mingo@kernel.org, dan.carpenter@oracle.com, marc.zyngier@arm.com, tglx@linutronix.de, antoine.tenart@free-electrons.com Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, jason@lakedaemon.net, mingo@kernel.org, tsahee@annapurnalabs.com, marc.zyngier@arm.com, dan.carpenter@oracle.com, tglx@linutronix.de, antoine.tenart@free-electrons.com In-Reply-To: <20160311081442.GE31887@mwanda> References: <20160311081442.GE31887@mwanda> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] irqchip/irq-alpine-msi: Release the correct domain on error Git-Commit-ID: 143d36a33b4d59a56bb8e913a17a105578fd3237 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 143d36a33b4d59a56bb8e913a17a105578fd3237 Gitweb: http://git.kernel.org/tip/143d36a33b4d59a56bb8e913a17a105578fd3237 Author: Dan Carpenter AuthorDate: Fri, 11 Mar 2016 11:14:43 +0300 Committer: Thomas Gleixner CommitDate: Fri, 11 Mar 2016 10:06:55 +0100 irqchip/irq-alpine-msi: Release the correct domain on error The "msi_domain" variable is NULL here so it leads to a NULL dereference. It looks like we actually intended to free "middle_domain". Fixes: e6b78f2c3e14 ('irqchip: Add the Alpine MSIX interrupt controller') Signed-off-by: Dan Carpenter Cc: Jason Cooper Cc: Marc Zyngier Cc: Antoine Tenart Cc: kernel-janitors@vger.kernel.org Cc: Tsahee Zidenberg Link: http://lkml.kernel.org/r/20160311081442.GE31887@mwanda Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-alpine-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index f871272..2538425 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -220,7 +220,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, middle_domain); if (!msi_domain) { pr_err("Failed to create MSI domain\n"); - irq_domain_remove(msi_domain); + irq_domain_remove(middle_domain); return -ENOMEM; }