From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbdBNGk5 (ORCPT ); Tue, 14 Feb 2017 01:40:57 -0500 Received: from terminus.zytor.com ([65.50.211.136]:56098 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306AbdBNGkz (ORCPT ); Tue, 14 Feb 2017 01:40:55 -0500 Date: Mon, 13 Feb 2017 22:40:39 -0800 From: "tip-bot for Steven Rostedt (VMware)" Message-ID: Cc: namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de, acme@redhat.com, hpa@zytor.com, wangnan0@huawei.com, mingo@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, dsahern@gmail.com, adrian.hunter@intel.com Reply-To: jolsa@kernel.org, tglx@linutronix.de, namhyung@kernel.org, acme@redhat.com, mingo@kernel.org, hpa@zytor.com, wangnan0@huawei.com, rostedt@goodmis.org, adrian.hunter@intel.com, dsahern@gmail.com, linux-kernel@vger.kernel.org In-Reply-To: <20170213121418.47f279e8@gandalf.local.home> References: <20170213121418.47f279e8@gandalf.local.home> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP Git-Commit-ID: 14e4d7e0abfdefabea2b8796c5a8b2b9c77b5326 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 14e4d7e0abfdefabea2b8796c5a8b2b9c77b5326 Gitweb: http://git.kernel.org/tip/14e4d7e0abfdefabea2b8796c5a8b2b9c77b5326 Author: Steven Rostedt (VMware) AuthorDate: Mon, 13 Feb 2017 12:11:44 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 13 Feb 2017 17:22:32 -0300 tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP A undefined value was being used for the OLD_RING_BUFFER_TYPE_TIME_STAMP case entry, as the 'length' variable was not being initialized, fix it. Caught by the reporter when building tools/perf/ using clang, which emmitted this warning: kbuffer-parse.c:312:7: warning: variable 'length' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case OLD_RINGBUF_TYPE_TIME_EXTEND: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ kbuffer-parse.c:339:29: note: uninitialized use occurs here kbuf->next = kbuf->index + length; ^~~~~~ kbuffer-parse.c:297:21: note: initialize the variable 'length' to silence this warning unsigned int length; ^ = 0 Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Steven Rostedt Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/r/20170213121418.47f279e8@gandalf.local.home Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/traceevent/kbuffer-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c index 65984f1..c94e364 100644 --- a/tools/lib/traceevent/kbuffer-parse.c +++ b/tools/lib/traceevent/kbuffer-parse.c @@ -315,6 +315,7 @@ static unsigned int old_update_pointers(struct kbuffer *kbuf) extend += delta; delta = extend; ptr += 4; + length = 0; break; case OLD_RINGBUF_TYPE_TIME_STAMP: