From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324AbdBXJSF (ORCPT ); Fri, 24 Feb 2017 04:18:05 -0500 Received: from terminus.zytor.com ([65.50.211.136]:50842 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbdBXJSC (ORCPT ); Fri, 24 Feb 2017 04:18:02 -0500 Date: Fri, 24 Feb 2017 01:15:30 -0800 From: tip-bot for Tan Xiaojun Message-ID: Cc: tanxiaojun@huawei.com, acme@kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, tglx@linutronix.de, vincent.weaver@maine.edu, eranian@google.com, linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com, mingo@kernel.org, jolsa@redhat.com, alexander.shishkin@linux.intel.com Reply-To: jolsa@redhat.com, alexander.shishkin@linux.intel.com, eranian@google.com, hpa@zytor.com, mingo@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, acme@kernel.org, tanxiaojun@huawei.com, vincent.weaver@maine.edu, tglx@linutronix.de, torvalds@linux-foundation.org In-Reply-To: <1487829879-56237-1-git-send-email-tanxiaojun@huawei.com> References: <1487829879-56237-1-git-send-email-tanxiaojun@huawei.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check Git-Commit-ID: 1572e45a924f254d9570093abde46430c3172e3d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1572e45a924f254d9570093abde46430c3172e3d Gitweb: http://git.kernel.org/tip/1572e45a924f254d9570093abde46430c3172e3d Author: Tan Xiaojun AuthorDate: Thu, 23 Feb 2017 14:04:39 +0800 Committer: Ingo Molnar CommitDate: Fri, 24 Feb 2017 08:56:33 +0100 perf/core: Fix the perf_cpu_time_max_percent check Use "proc_dointvec_minmax" instead of "proc_dointvec" to check the input value from user-space. If not, we can set a big value and some vars will overflow like "sysctl_perf_event_sample_rate" which will cause a lot of unexpected problems. Signed-off-by: Tan Xiaojun Signed-off-by: Peter Zijlstra (Intel) Cc: Cc: Cc: Alexander Shishkin Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Link: http://lkml.kernel.org/r/1487829879-56237-1-git-send-email-tanxiaojun@huawei.com Signed-off-by: Ingo Molnar --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index d4e3f8d..c1c1cdf 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -455,7 +455,7 @@ int perf_cpu_time_max_percent_handler(struct ctl_table *table, int write, void __user *buffer, size_t *lenp, loff_t *ppos) { - int ret = proc_dointvec(table, write, buffer, lenp, ppos); + int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); if (ret || !write) return ret;