From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753115AbdI1K7g (ORCPT ); Thu, 28 Sep 2017 06:59:36 -0400 Received: from terminus.zytor.com ([65.50.211.136]:35627 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbdI1K7e (ORCPT ); Thu, 28 Sep 2017 06:59:34 -0400 Date: Thu, 28 Sep 2017 03:55:20 -0700 From: tip-bot for Josh Poimboeuf Message-ID: Cc: boris.ostrovsky@oracle.com, jpoimboe@redhat.com, jslaby@suse.cz, torvalds@linux-foundation.org, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, jgross@suse.com, mingo@kernel.org, luto@kernel.org, peterz@infradead.org Reply-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, jgross@suse.com, mingo@kernel.org, peterz@infradead.org, luto@kernel.org, jslaby@suse.cz, torvalds@linux-foundation.org, boris.ostrovsky@oracle.com, jpoimboe@redhat.com, hpa@zytor.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:core/objtool] x86/head: Remove confusing comment Git-Commit-ID: 17270717e80de33a884ad328fea5f407d87f6d6a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 17270717e80de33a884ad328fea5f407d87f6d6a Gitweb: https://git.kernel.org/tip/17270717e80de33a884ad328fea5f407d87f6d6a Author: Josh Poimboeuf AuthorDate: Mon, 18 Sep 2017 21:43:31 -0500 Committer: Ingo Molnar CommitDate: Thu, 28 Sep 2017 09:39:02 +0200 x86/head: Remove confusing comment This comment is actively wrong and confusing. It refers to the registers' stack offsets after the pt_regs has been constructed on the stack, but this code is *before* that. At this point the stack just has the standard iret frame, for which no comment should be needed. Signed-off-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Boris Ostrovsky Cc: Jiri Slaby Cc: Juergen Gross Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/a3c267b770fc56c9b86df9c11c552848248aace2.1505764066.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/head_64.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S index 513cbb0..3b04e4c 100644 --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -270,10 +270,6 @@ bad_address: __INIT ENTRY(early_idt_handler_array) - # 104(%rsp) %rflags - # 96(%rsp) %cs - # 88(%rsp) %rip - # 80(%rsp) error code i = 0 .rept NUM_EXCEPTION_VECTORS .ifeq (EXCEPTION_ERRCODE_MASK >> i) & 1