From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161130AbcFCK7j (ORCPT ); Fri, 3 Jun 2016 06:59:39 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56790 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964775AbcFCK7h (ORCPT ); Fri, 3 Jun 2016 06:59:37 -0400 Date: Fri, 3 Jun 2016 03:58:59 -0700 From: tip-bot for Sebastian Andrzej Siewior Message-ID: Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, mingo@kernel.org, peterz@infradead.org, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, bigeasy@linutronix.de, hpa@zytor.com Reply-To: bigeasy@linutronix.de, hpa@zytor.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, mingo@kernel.org In-Reply-To: <1464356838-1755-1-git-send-email-bigeasy@linutronix.de> References: <1464356838-1755-1-git-send-email-bigeasy@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/core] locking/rtmutex: Only warn once on a trylock from bad context Git-Commit-ID: 17544d7dc82bc0ce43ba7e3f12d37c6a2337dc01 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 17544d7dc82bc0ce43ba7e3f12d37c6a2337dc01 Gitweb: http://git.kernel.org/tip/17544d7dc82bc0ce43ba7e3f12d37c6a2337dc01 Author: Sebastian Andrzej Siewior AuthorDate: Fri, 27 May 2016 15:47:18 +0200 Committer: Ingo Molnar CommitDate: Fri, 3 Jun 2016 12:06:12 +0200 locking/rtmutex: Only warn once on a trylock from bad context One warning should be enough to get one motivated to fix this. It is possible that this happens more than once and that starts flooding the output. Later the prints will be suppressed so we only get half of it. Depending on the console system used it might not be helpful. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Peter Zijlstra (Intel) Cc: Andrew Morton Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1464356838-1755-1-git-send-email-bigeasy@linutronix.de Signed-off-by: Ingo Molnar --- kernel/locking/rtmutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 3e74660..1ec0f48 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL_GPL(rt_mutex_timed_lock); */ int __sched rt_mutex_trylock(struct rt_mutex *lock) { - if (WARN_ON(in_irq() || in_nmi() || in_serving_softirq())) + if (WARN_ON_ONCE(in_irq() || in_nmi() || in_serving_softirq())) return 0; return rt_mutex_fasttrylock(lock, rt_mutex_slowtrylock);