mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot for Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
	hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:core/rcu] rcu: Make task_subsys_state() RCU-lockdep checks handle boot-time use
Date: Sun, 28 Feb 2010 08:59:17 GMT	[thread overview]
Message-ID: <tip-1883c79a57a5fe25309007590cccb1b2782c41b2@git.kernel.org> (raw)
In-Reply-To: <1267311188-16603-2-git-send-email-paulmck@linux.vnet.ibm.com>

Commit-ID:  1883c79a57a5fe25309007590cccb1b2782c41b2
Gitweb:     http://git.kernel.org/tip/1883c79a57a5fe25309007590cccb1b2782c41b2
Author:     Paul E. McKenney <paulmck@linux.vnet.ibm.com>
AuthorDate: Sat, 27 Feb 2010 14:53:08 -0800
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 28 Feb 2010 09:17:42 +0100

rcu: Make task_subsys_state() RCU-lockdep checks handle boot-time use

It is apparently legal to invoke task_subsys_state() without RCU
protection during early boot time.  After all, there are no
concurrent tasks, so there can be no grace periods completing
concurrently.

But this does need an Acked-by from the cgroups folks.

Located-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: mathieu.desnoyers@polymtl.ca
Cc: josh@joshtriplett.org
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
Cc: Valdis.Kletnieks@vt.edu
Cc: dhowells@redhat.com
LKML-Reference: <1267311188-16603-2-git-send-email-paulmck@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/cgroup.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index c9bbcb2..a73e1ce 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -489,6 +489,7 @@ static inline struct cgroup_subsys_state *task_subsys_state(
 {
 	return rcu_dereference_check(task->cgroups->subsys[subsys_id],
 				     rcu_read_lock_held() ||
+				     !rcu_scheduler_active ||
 				     cgroup_lock_is_held());
 }
 

  reply	other threads:[~2010-02-28  9:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-27 22:52 [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Paul E. McKenney
2010-02-27 22:53 ` [PATCH tip/core/rcu 1/2] rcu: fix holdoff for accelerated GPs for last non-dynticked CPU Paul E. McKenney
2010-02-28  8:59   ` [tip:core/rcu] rcu: Fix " tip-bot for Paul E. McKenney
2010-03-16 11:00     ` Ingo Molnar
2010-03-16 11:03       ` Ingo Molnar
2010-03-16 11:51         ` Ingo Molnar
2010-03-16 12:15           ` Ingo Molnar
2010-03-16 13:30             ` Paul E. McKenney
2010-03-17 17:53         ` Ingo Molnar
2010-03-17 19:22           ` Paul E. McKenney
2010-03-17 19:35             ` Ingo Molnar
2010-02-27 22:53 ` [PATCH tip/core/rcu 2/2] rcu: make task_subsys_state() RCU-lockdep checks handle boot-time use Paul E. McKenney
2010-02-28  8:59   ` tip-bot for Paul E. McKenney [this message]
2010-03-01 19:47     ` [tip:core/rcu] rcu: Make " Paul Menage
2010-02-28  8:55 ` [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Ingo Molnar
2010-02-28 16:32   ` Paul E. McKenney
2010-03-01  8:33     ` [tip:core/rcu] sched, rcu: Fix rcu_dereference() for RCU-lockdep tip-bot for Paul E. McKenney
2010-03-01 12:10     ` [PATCH tip/core/rcu 0/2] more lockdep-RCU and RCU_FAST_NO_HZ fixes Ingo Molnar
2010-03-01 16:08       ` Paul E. McKenney
2010-03-01 17:58         ` Peter Zijlstra
2010-03-01 18:50           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1883c79a57a5fe25309007590cccb1b2782c41b2@git.kernel.org \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome