From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965526AbeAJM1z (ORCPT + 1 other); Wed, 10 Jan 2018 07:27:55 -0500 Received: from terminus.zytor.com ([65.50.211.136]:57011 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965444AbeAJM1w (ORCPT ); Wed, 10 Jan 2018 07:27:52 -0500 Date: Wed, 10 Jan 2018 04:16:03 -0800 From: tip-bot for Joel Fernandes Message-ID: Cc: jbacik@fb.com, patrick.bellasi@arm.com, morten.rasmussen@arm.com, Chris.Redpath@arm.com, skannan@quicinc.com, joelaf@google.com, eas-dev@lists.linaro.org, hpa@zytor.com, vincent.guittot@linaro.org, tglx@linutronix.de, rostedt@goodmis.org, fweisbec@gmail.com, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com, rjw@rjwysocki.net, juri.lelli@arm.com, smuckle@google.com, atish.patra@oracle.com, markivx@codeaurora.org, peterz@infradead.org, mingo@kernel.org, rohit.k.jain@oracle.com, dietmar.eggemann@arm.com, brendan.jackman@arm.com, lenb@kernel.org, viresh.kumar@linaro.org, kernel-team@android.com, torvalds@linux-foundation.org Reply-To: jbacik@fb.com, patrick.bellasi@arm.com, morten.rasmussen@arm.com, Chris.Redpath@arm.com, skannan@quicinc.com, joelaf@google.com, hpa@zytor.com, vincent.guittot@linaro.org, eas-dev@lists.linaro.org, tglx@linutronix.de, rostedt@goodmis.org, fweisbec@gmail.com, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, srinivas.pandruvada@linux.intel.com, juri.lelli@arm.com, smuckle@google.com, atish.patra@oracle.com, peterz@infradead.org, markivx@codeaurora.org, rohit.k.jain@oracle.com, mingo@kernel.org, dietmar.eggemann@arm.com, brendan.jackman@arm.com, lenb@kernel.org, torvalds@linux-foundation.org, kernel-team@android.com, viresh.kumar@linaro.org In-Reply-To: <20171215153944.220146-3-joelaf@google.com> References: <20171215153944.220146-3-joelaf@google.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/fair: Remove impossible condition from find_idlest_group_cpu() Git-Commit-ID: 18cec7e0ddd5e28b7722f7049d715873373be3e9 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 18cec7e0ddd5e28b7722f7049d715873373be3e9 Gitweb: https://git.kernel.org/tip/18cec7e0ddd5e28b7722f7049d715873373be3e9 Author: Joel Fernandes AuthorDate: Fri, 15 Dec 2017 07:39:44 -0800 Committer: Ingo Molnar CommitDate: Wed, 10 Jan 2018 11:30:30 +0100 sched/fair: Remove impossible condition from find_idlest_group_cpu() find_idlest_group_cpu() goes through CPUs of a group previous selected by find_idlest_group(). find_idlest_group() returns NULL if the local group is the selected one and doesn't execute find_idlest_group_cpu if the group to which 'cpu' belongs to is chosen. So we're always guaranteed to call find_idlest_group_cpu() with a group to which 'cpu' is non-local. This makes one of the conditions in find_idlest_group_cpu() an impossible one, which we can get rid off. Signed-off-by: Joel Fernandes Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Brendan Jackman Reviewed-by: Vincent Guittot Cc: Android Kernel Cc: Atish Patra Cc: Chris Redpath Cc: Dietmar Eggemann Cc: EAS Dev Cc: Frederic Weisbecker Cc: Josef Bacik Cc: Juri Lelli Cc: Len Brown Cc: Linus Torvalds Cc: Morten Ramussen Cc: Patrick Bellasi Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Rohit Jain Cc: Saravana Kannan Cc: Srinivas Pandruvada Cc: Steve Muckle Cc: Steven Rostedt Cc: Thomas Gleixner Cc: Vikram Mulukutla Cc: Viresh Kumar Link: http://lkml.kernel.org/r/20171215153944.220146-3-joelaf@google.com Signed-off-by: Ingo Molnar --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6e775ac..3e7606d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5950,7 +5950,7 @@ find_idlest_group_cpu(struct sched_group *group, struct task_struct *p, int this } } else if (shallowest_idle_cpu == -1) { load = weighted_cpuload(cpu_rq(i)); - if (load < min_load || (load == min_load && i == this_cpu)) { + if (load < min_load) { min_load = load; least_loaded_cpu = i; }