From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbdCAKnh (ORCPT ); Wed, 1 Mar 2017 05:43:37 -0500 Received: from terminus.zytor.com ([65.50.211.136]:48458 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbdCAKne (ORCPT ); Wed, 1 Mar 2017 05:43:34 -0500 Date: Wed, 1 Mar 2017 01:48:47 -0800 From: tip-bot for Andrew Banman Message-ID: Cc: torvalds@linux-foundation.org, mingo@kernel.org, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, peterz@infradead.org, jpoimboe@redhat.com, tglx@linutronix.de, luto@kernel.org, hpa@zytor.com, bp@alien8.de, abanman@hpe.com, mike.travis@hpe.com, brgerst@gmail.com Reply-To: tglx@linutronix.de, luto@kernel.org, jpoimboe@redhat.com, abanman@hpe.com, bp@alien8.de, brgerst@gmail.com, mike.travis@hpe.com, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, dvlasenk@redhat.com In-Reply-To: <1487351269-181133-1-git-send-email-abanman@hpe.com> References: <1487351269-181133-1-git-send-email-abanman@hpe.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register Git-Commit-ID: 1b17c6df852851b40c3c27c66b8fa2fd99cf25d8 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1b17c6df852851b40c3c27c66b8fa2fd99cf25d8 Gitweb: http://git.kernel.org/tip/1b17c6df852851b40c3c27c66b8fa2fd99cf25d8 Author: Andrew Banman AuthorDate: Fri, 17 Feb 2017 11:07:49 -0600 Committer: Ingo Molnar CommitDate: Wed, 1 Mar 2017 10:28:20 +0100 x86/platform/uv/BAU: Fix HUB errors by remove initial write to sw-ack register Writing to the software acknowledge clear register when there are no pending messages causes a HUB error to assert. The original intent of this write was to clear the pending bits before start of operation, but this is an incorrect method and has been determined to be unnecessary. Signed-off-by: Andrew Banman Acked-by: Mike Travis Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: akpm@linux-foundation.org Cc: rja@hpe.com Cc: sivanich@hpe.com Link: http://lkml.kernel.org/r/1487351269-181133-1-git-send-email-abanman@hpe.com Signed-off-by: Ingo Molnar --- arch/x86/platform/uv/tlb_uv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c index 766d4d3..f25982c 100644 --- a/arch/x86/platform/uv/tlb_uv.c +++ b/arch/x86/platform/uv/tlb_uv.c @@ -1847,7 +1847,6 @@ static void pq_init(int node, int pnode) ops.write_payload_first(pnode, first); ops.write_payload_last(pnode, last); - ops.write_g_sw_ack(pnode, 0xffffUL); /* in effect, all msg_type's are set to MSG_NOOP */ memset(pqp, 0, sizeof(struct bau_pq_entry) * DEST_Q_SIZE);