mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	khali@linux-fr.org, tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/urgent] x86, cpufeature: Remove stray %s, add -w to mkcapflags.pl
Date: Tue, 26 Jun 2012 08:20:50 -0700	[thread overview]
Message-ID: <tip-1b6b7c9ff3514772958c075f8c89e42dddf6a4d8@git.kernel.org> (raw)
In-Reply-To: <20120626143246.0c9bf301@endymion.delvare>

Commit-ID:  1b6b7c9ff3514772958c075f8c89e42dddf6a4d8
Gitweb:     http://git.kernel.org/tip/1b6b7c9ff3514772958c075f8c89e42dddf6a4d8
Author:     H. Peter Anvin <hpa@zytor.com>
AuthorDate: Tue, 26 Jun 2012 07:58:23 -0700
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 26 Jun 2012 08:02:48 -0700

x86, cpufeature: Remove stray %s, add -w to mkcapflags.pl

There was a stray %s left from testing, remove it.

Add -w to the #! line (which is parsed by Perl even if the Perl
interpreter is invoked explicitly on the command line) to catch these
kinds of errors in the future.

Reported-by: Jean Delvare <khali@linux-fr.org>
Link: http://lkml.kernel.org/r/20120626143246.0c9bf301@endymion.delvare
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/cpu/mkcapflags.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mkcapflags.pl b/arch/x86/kernel/cpu/mkcapflags.pl
index 0c5b549..c7b3fe2 100644
--- a/arch/x86/kernel/cpu/mkcapflags.pl
+++ b/arch/x86/kernel/cpu/mkcapflags.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/perl -w
 #
 # Generate the x86_cap_flags[] array from include/asm-x86/cpufeature.h
 #
@@ -29,7 +29,7 @@ while (defined($line = <IN>)) {
 			print STDERR "$in: duplicate feature name: $feature\n";
 			$err++;
 		}
-		printf OUT "\t%-32s = \"%s\",%s\n", "[$macro]", $feature;
+		printf OUT "\t%-32s = \"%s\",\n", "[$macro]", $feature;
 	}
 }
 print OUT "};\n";

      parent reply	other threads:[~2012-06-26 15:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 14:28 [PATCH] x86, cpufeature: Fix duplicate feature name "dts" Jean Delvare
2012-06-21 16:28 ` H. Peter Anvin
2012-06-21 17:07   ` Jean Delvare
2012-06-21 18:06     ` H. Peter Anvin
2012-06-21 18:44       ` Borislav Petkov
2012-06-21 20:11         ` H. Peter Anvin
2012-06-22  6:59           ` Ingo Molnar
2012-06-22 18:01             ` H. Peter Anvin
2012-06-22 18:49               ` Guenter Roeck
2012-06-22  7:02   ` Jan Beulich
2012-06-22 13:38     ` H. Peter Anvin
2012-06-22 20:38   ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-24 19:49     ` Jean Delvare
2012-06-24 20:37       ` H. Peter Anvin
2012-06-26  9:13         ` Jean Delvare
2012-06-24 20:39       ` H. Peter Anvin
2012-06-24 20:59         ` H. Peter Anvin
2012-06-22 20:39   ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-25 16:13   ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-25 16:14   ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-26 12:32     ` Jean Delvare
2012-06-26 14:48       ` H. Peter Anvin
2012-06-26 15:20       ` tip-bot for H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1b6b7c9ff3514772958c075f8c89e42dddf6a4d8@git.kernel.org \
    --to=hpa@zytor.com \
    --cc=hpa@linux.intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®