From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2260WuV9TScP5j5NVkj/3vRDSmp5mHqmfKWQtVLmJ/Vjp4pHHS10JhIOzuj6chblEbuIavKL ARC-Seal: i=1; a=rsa-sha256; t=1516794502; cv=none; d=google.com; s=arc-20160816; b=QdXe3aZ2VVPPs/2IOJJC72fqBhDjS48IXcor/m7kequVBBXuHn4mb1Y2C5t/Rk/ouL rJMPg5pvm+p/KH/dN7np05iAv0syz9UItKmGeT/1JSIxH2FrYnDPBGQGb2OcDaENxyIu +eta9VmQbp+ZtfZN2G2Avmp+WEN1+4cCE4b8vpEhQBaz2tIjkD6IwZyHuOt/4T66sNS1 zrqspwzCOhTcx5vI5LeaNjAKAKeEQFZa99aYX6D5saUhTELS7c7W0S+TdOCIwj1XPJYN dXzJVYbFMs3uQ8t+Q582Z81EUrd4jnExQvY469BkVxqHh8+uAoagfE8AOKLfDoN5zkAs +u4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=precedence:content-disposition:content-transfer-encoding :mime-version:robot-unsubscribe:robot-id:git-commit-id:subject:to :references:in-reply-to:reply-to:cc:message-id:from:sender:date :arc-authentication-results; bh=BxqzbFmiATsBFCg2bsoQoL5FO9vtsT3m/dn0Yjsim3I=; b=wSlOu3XUCYjxaHQRurEjwTBgj7nptKE4scsm7E2hNUPi+heqqs05hTEnpqJOlpZS33 ekJnvdFmkWpa+CnbHnS74ysmo3YR+9w9RW7cFsAY3yOX1nNTjS/tPGZxrUwnyLIF8QbM eJlMC+74RvvquymqcP3RrD3dhjK8WivAyTx4lgJUsus+n+YgVpAfsYKsc9TfN+b/Pu6x oePoJi9CudUVGo+wcr6bxaiVe2mjT6MQl4lo840v4aLf6FKwJv7YL1e3Qyif3i+sSghE U2YgZMmmPIwMw5if8rMKBF5gNhl225hGAwelWNp34kwVFRq75OXyxceck7qs8YwdaAsi rLVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tipbot@zytor.com designates 65.50.211.136 as permitted sender) smtp.mailfrom=tipbot@zytor.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of tipbot@zytor.com designates 65.50.211.136 as permitted sender) smtp.mailfrom=tipbot@zytor.com Date: Wed, 24 Jan 2018 03:42:54 -0800 Sender: tip tree robot From: tip-bot for Waiman Long Message-ID: Cc: peterz@infradead.org, luto@amacapital.net, dave.hansen@intel.com, dwmw@amazon.co.uk, gregkh@linux-foundation.org, tim.c.chen@linux.intel.com, jikos@kernel.org, arjan@linux.intel.com, tglx@linutronix.de, law@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, hpa@zytor.com, keescook@google.com, thomas.lendacky@amd.com, ak@linux.intel.com, torvalds@linux-foundation.org, longman@redhat.com, pjt@google.com Reply-To: peterz@infradead.org, luto@amacapital.net, dave.hansen@intel.com, dwmw@amazon.co.uk, gregkh@linux-foundation.org, arjan@linux.intel.com, jikos@kernel.org, tim.c.chen@linux.intel.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, law@redhat.com, jpoimboe@redhat.com, thomas.lendacky@amd.com, keescook@google.com, hpa@zytor.com, torvalds@linux-foundation.org, ak@linux.intel.com, pjt@google.com, longman@redhat.com In-Reply-To: <1516658974-27852-1-git-send-email-longman@redhat.com> References: <1516658974-27852-1-git-send-email-longman@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] x86/retpoline: Remove the esp/rsp thunk Git-Commit-ID: 1df37383a8aeabb9b418698f0bcdffea01f4b1b2 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590332241345318630?= X-GMAIL-MSGID: =?utf-8?q?1590474312155757853?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Commit-ID: 1df37383a8aeabb9b418698f0bcdffea01f4b1b2 Gitweb: https://git.kernel.org/tip/1df37383a8aeabb9b418698f0bcdffea01f4b1b2 Author: Waiman Long AuthorDate: Mon, 22 Jan 2018 17:09:34 -0500 Committer: Thomas Gleixner CommitDate: Wed, 24 Jan 2018 12:31:55 +0100 x86/retpoline: Remove the esp/rsp thunk It doesn't make sense to have an indirect call thunk with esp/rsp as retpoline code won't work correctly with the stack pointer register. Removing it will help compiler writers to catch error in case such a thunk call is emitted incorrectly. Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support") Suggested-by: Jeff Law Signed-off-by: Waiman Long Signed-off-by: Thomas Gleixner Acked-by: David Woodhouse Cc: Tom Lendacky Cc: Kees Cook Cc: Andi Kleen Cc: Tim Chen Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Jiri Kosina Cc: Andy Lutomirski Cc: Dave Hansen Cc: Josh Poimboeuf Cc: Arjan van de Ven Cc: Greg Kroah-Hartman Cc: Paul Turner Link: https://lkml.kernel.org/r/1516658974-27852-1-git-send-email-longman@redhat.com --- arch/x86/include/asm/asm-prototypes.h | 1 - arch/x86/lib/retpoline.S | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h index 0927cdc..1908214 100644 --- a/arch/x86/include/asm/asm-prototypes.h +++ b/arch/x86/include/asm/asm-prototypes.h @@ -38,5 +38,4 @@ INDIRECT_THUNK(dx) INDIRECT_THUNK(si) INDIRECT_THUNK(di) INDIRECT_THUNK(bp) -INDIRECT_THUNK(sp) #endif /* CONFIG_RETPOLINE */ diff --git a/arch/x86/lib/retpoline.S b/arch/x86/lib/retpoline.S index dfb2ba9..c909961 100644 --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -36,7 +36,6 @@ GENERATE_THUNK(_ASM_DX) GENERATE_THUNK(_ASM_SI) GENERATE_THUNK(_ASM_DI) GENERATE_THUNK(_ASM_BP) -GENERATE_THUNK(_ASM_SP) #ifdef CONFIG_64BIT GENERATE_THUNK(r8) GENERATE_THUNK(r9)