From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754444AbeAQQiD (ORCPT ); Wed, 17 Jan 2018 11:38:03 -0500 Received: from terminus.zytor.com ([65.50.211.136]:34071 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbeAQQh7 (ORCPT ); Wed, 17 Jan 2018 11:37:59 -0500 Date: Wed, 17 Jan 2018 08:35:24 -0800 From: tip-bot for Jin Yao Message-ID: Cc: tglx@linutronix.de, kan.liang@intel.com, hpa@zytor.com, jolsa@redhat.com, mingo@kernel.org, yao.jin@linux.intel.com, acme@redhat.com, linux-kernel@vger.kernel.org, ak@linux.intel.com, peterz@infradead.org, alexander.shishkin@linux.intel.com Reply-To: yao.jin@linux.intel.com, mingo@kernel.org, acme@redhat.com, tglx@linutronix.de, jolsa@redhat.com, hpa@zytor.com, kan.liang@intel.com, alexander.shishkin@linux.intel.com, peterz@infradead.org, ak@linux.intel.com, linux-kernel@vger.kernel.org In-Reply-To: <1515596433-24653-3-git-send-email-yao.jin@linux.intel.com> References: <1515596433-24653-3-git-send-email-yao.jin@linux.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf script: Improve error msg when no first/last sample time found Git-Commit-ID: 1e2778e91616086177a255f3fc8c72ecaa564ae6 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 1e2778e91616086177a255f3fc8c72ecaa564ae6 Gitweb: https://git.kernel.org/tip/1e2778e91616086177a255f3fc8c72ecaa564ae6 Author: Jin Yao AuthorDate: Wed, 10 Jan 2018 23:00:27 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:23:34 -0300 perf script: Improve error msg when no first/last sample time found The following message will be returned to user when executing 'perf script --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to set '--timestamp-boundary')." Signed-off-by: Jin Yao Reviewed-by: Jiri Olsa Cc: Alexander Shishkin Cc: Andi Kleen Cc: Kan Liang Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1515596433-24653-3-git-send-email-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-script.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 08bc818..ac78191 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -3449,7 +3449,9 @@ int cmd_script(int argc, const char **argv) if (perf_time__parse_str(script.ptime_range, script.time_str) != 0) { if (session->evlist->first_sample_time == 0 && session->evlist->last_sample_time == 0) { - pr_err("No first/last sample time in perf data\n"); + pr_err("HINT: no first/last sample time found in perf data.\n" + "Please use latest perf binary to execute 'perf record'\n" + "(if '--buildid-all' is enabled, please set '--timestamp-boundary').\n"); err = -EINVAL; goto out_delete; }