mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Nick Desaulniers <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: ndesaulniers@google.com, mingo@kernel.org,
	linux-kernel@vger.kernel.org, jgross@suse.com,
	ben.hutchings@codethink.co.uk, hpa@zytor.com, tglx@linutronix.de,
	boris.ostrovsky@oracle.com, gregkh@linuxfoundation.org
Subject: [tip:x86/urgent] x86/irqflags: Mark native_restore_fl extern inline
Date: Thu, 30 Aug 2018 02:40:42 -0700	[thread overview]
Message-ID: <tip-1f59a4581b5ecfe9b4f049a7a2cf904d8352842d@git.kernel.org> (raw)
In-Reply-To: <20180827214011.55428-1-ndesaulniers@google.com>

Commit-ID:  1f59a4581b5ecfe9b4f049a7a2cf904d8352842d
Gitweb:     https://git.kernel.org/tip/1f59a4581b5ecfe9b4f049a7a2cf904d8352842d
Author:     Nick Desaulniers <ndesaulniers@google.com>
AuthorDate: Mon, 27 Aug 2018 14:40:09 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 30 Aug 2018 11:37:09 +0200

x86/irqflags: Mark native_restore_fl extern inline

This should have been marked extern inline in order to pick up the out
of line definition in arch/x86/kernel/irqflags.S.

Fixes: 208cbb325589 ("x86/irqflags: Provide a declaration for native_save_fl")
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180827214011.55428-1-ndesaulniers@google.com

---
 arch/x86/include/asm/irqflags.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index c14f2a74b2be..15450a675031 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -33,7 +33,8 @@ extern inline unsigned long native_save_fl(void)
 	return flags;
 }
 
-static inline void native_restore_fl(unsigned long flags)
+extern inline void native_restore_fl(unsigned long flags);
+extern inline void native_restore_fl(unsigned long flags)
 {
 	asm volatile("push %0 ; popf"
 		     : /* no output */

      parent reply	other threads:[~2018-08-30  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 21:40 [PATCH] x86/irqflags: mark " Nick Desaulniers
2018-08-28  5:13 ` Greg Kroah-Hartman
2018-08-28  6:02   ` Juergen Gross
2018-08-28 12:43     ` Greg Kroah-Hartman
2018-08-28 22:41       ` Nick Desaulniers
2018-08-28  6:01 ` Juergen Gross
2018-08-30  9:40 ` tip-bot for Nick Desaulniers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1f59a4581b5ecfe9b4f049a7a2cf904d8352842d@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=boris.ostrovsky@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®