mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Javier Martinez Canillas <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net,
	grant.likely@linaro.org, hpa@zytor.com, mingo@kernel.org,
	javier.martinez@collabora.co.uk, benh@kernel.crashing.org,
	ralf@linux-mips.org, linux@arm.linux.org.uk, andrew@lunn.ch,
	tglx@linutronix.de, sameo@linux.intel.com,
	linus.walleij@linaro.org
Subject: [tip:irq/core] genirq: Add irq_get_trigger_type() to get IRQ flags
Date: Tue, 25 Jun 2013 02:52:17 -0700	[thread overview]
Message-ID: <tip-1f6236bfd7c38d5f9f7648fae7215e65274b9e63@git.kernel.org> (raw)
In-Reply-To: <1371228049-27080-2-git-send-email-javier.martinez@collabora.co.uk>

Commit-ID:  1f6236bfd7c38d5f9f7648fae7215e65274b9e63
Gitweb:     http://git.kernel.org/tip/1f6236bfd7c38d5f9f7648fae7215e65274b9e63
Author:     Javier Martinez Canillas <javier.martinez@collabora.co.uk>
AuthorDate: Fri, 14 Jun 2013 18:40:43 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 25 Jun 2013 11:48:24 +0200

genirq: Add irq_get_trigger_type() to get IRQ flags

Drivers that want to get the trigger edge/level type flags for a given
interrupt have to call irq_get_irq_data(irq) to get the struct
irq_data and then irqd_get_trigger_type(irq_data) to obtain the IRQ
flags.

This is not only error prone but also unnecessary exposes the struct
irq_data to callers.

It's better to have an irq_get_trigger_type() function to obtain the
edge/level flags for an IRQ.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: Grant Likely <grant.likely@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mips@linux-mips.org
Link: http://lkml.kernel.org/r/1371228049-27080-2-git-send-email-javier.martinez@collabora.co.uk
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/irq.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 298a9b9..f04d3ba 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -584,6 +584,12 @@ static inline struct msi_desc *irq_data_get_msi(struct irq_data *d)
 	return d->msi_desc;
 }
 
+static inline u32 irq_get_trigger_type(unsigned int irq)
+{
+	struct irq_data *d = irq_get_irq_data(irq);
+	return d ? irqd_get_trigger_type(d) : 0;
+}
+
 int __irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node,
 		struct module *owner);
 

  reply	other threads:[~2013-06-25  9:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 16:40 [PATCH 0/7] genirq: add " Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 1/7] " Javier Martinez Canillas
2013-06-25  9:52   ` tip-bot for Javier Martinez Canillas [this message]
2013-06-14 16:40 ` [PATCH 2/7] gpio: mvebu: use " Javier Martinez Canillas
2013-06-14 18:37   ` Jason Cooper
2013-06-25  9:52   ` [tip:irq/core] gpio: mvebu: Use " tip-bot for Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 3/7] mfd: twl4030-irq: use " Javier Martinez Canillas
2013-06-18  8:46   ` Samuel Ortiz
2013-06-25  9:52   ` [tip:irq/core] mfd: twl4030-irq: Use " tip-bot for Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 4/7] mfd: stmpe: use " Javier Martinez Canillas
2013-06-17  9:20   ` Linus Walleij
2013-06-18  8:45   ` Samuel Ortiz
2013-06-25  9:52   ` [tip:irq/core] " tip-bot for Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 5/7] arm: orion: " Javier Martinez Canillas
2013-06-14 18:37   ` Jason Cooper
2013-06-25  9:52   ` [tip:irq/core] arm: orion: Use " tip-bot for Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 6/7] MIPS: octeon: use " Javier Martinez Canillas
2013-06-14 17:20   ` David Daney
2013-06-25  9:53   ` [tip:irq/core] MIPS: octeon: Use " tip-bot for Javier Martinez Canillas
2013-06-14 16:40 ` [PATCH 7/7] irqdomain: use " Javier Martinez Canillas
2013-06-25  9:53   ` [tip:irq/core] irqdomain: Use " tip-bot for Javier Martinez Canillas
2013-06-17 22:29 ` [PATCH 0/7] genirq: add " Grant Likely
2013-06-25  7:11   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1f6236bfd7c38d5f9f7648fae7215e65274b9e63@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=andrew@lunn.ch \
    --cc=benh@kernel.crashing.org \
    --cc=grant.likely@linaro.org \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=sameo@linux.intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome