mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Michal Schmidt <mschmidt@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	mschmidt@redhat.com, jeremy@goop.org, arjan@infradead.org,
	tj@kernel.org, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/asm] x86: Detect stack protector for i386 builds on x86_64
Date: Sun, 30 Aug 2009 18:43:07 GMT	[thread overview]
Message-ID: <tip-23386d63bbb3199cf247313ec088878d72debcfd@git.kernel.org> (raw)
In-Reply-To: <20090829182718.10f566b1@leela>

Commit-ID:  23386d63bbb3199cf247313ec088878d72debcfd
Gitweb:     http://git.kernel.org/tip/23386d63bbb3199cf247313ec088878d72debcfd
Author:     Michal Schmidt <mschmidt@redhat.com>
AuthorDate: Sat, 29 Aug 2009 18:27:18 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 30 Aug 2009 20:39:48 +0200

x86: Detect stack protector for i386 builds on x86_64

Stack protector support was not detected when building with
ARCH=i386 on x86_64 systems:

  arch/x86/Makefile:80: stack protector enabled but no compiler support

The "-m32" argument needs to be passed to the detection script.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Arjan van de Ven <arjan@infradead.org>
LKML-Reference: <20090829182718.10f566b1@leela>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--


---
 arch/x86/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 1b68659..5e7db44 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -72,7 +72,7 @@ endif
 
 ifdef CONFIG_CC_STACKPROTECTOR
 	cc_has_sp := $(srctree)/scripts/gcc-x86_$(BITS)-has-stack-protector.sh
-        ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC)),y)
+        ifeq ($(shell $(CONFIG_SHELL) $(cc_has_sp) $(CC) $(biarch)),y)
                 stackp-y := -fstack-protector
                 stackp-$(CONFIG_CC_STACKPROTECTOR_ALL) += -fstack-protector-all
                 KBUILD_CFLAGS += $(stackp-y)

  parent reply	other threads:[~2009-08-30 18:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-29 16:27 [PATCH] x86: detect " Michal Schmidt
2009-08-30 13:39 ` Américo Wang
2009-08-30 18:43 ` tip-bot for Michal Schmidt [this message]
2009-09-01 10:03   ` [tip:x86/asm] x86: Detect " Ingo Molnar
2009-09-01 11:39     ` [PATCH] kthreads: Fix startup synchronization boot crash Ingo Molnar
2009-09-01 13:04       ` Oleg Nesterov
2009-09-01 13:14         ` Ingo Molnar
2009-09-01 13:37           ` Oleg Nesterov
2009-09-01 13:59             ` Ingo Molnar
2009-09-01 14:55               ` Oleg Nesterov
2009-09-01 15:54                 ` Ingo Molnar
2009-09-01 16:00                   ` Oleg Nesterov
2009-09-02 13:06                     ` Ingo Molnar
2009-09-01 16:52                 ` [PATCH 0/1] kthreads: simplify !kthreadd_task logic, kill kthreadd_task_init_done Oleg Nesterov
2009-09-01 16:53                   ` [PATCH 1/1] " Oleg Nesterov
2009-09-01 23:22                   ` [PATCH 0/1] " Eric W. Biederman
2009-09-02  9:13                     ` Oleg Nesterov
2009-09-04  7:37                       ` Ingo Molnar
2009-09-18 16:32                         ` Wu Fei
2009-09-18 18:54                           ` Oleg Nesterov
2009-09-18 19:17                             ` Linus Torvalds
2009-09-18 21:12                               ` Oleg Nesterov
2009-09-18 21:15                                 ` Oleg Nesterov
2009-09-18 22:06                                 ` Linus Torvalds
2009-09-18 23:11                                   ` Eric W. Biederman
2009-09-18 23:22                                   ` Oleg Nesterov
2009-09-18 23:38                                     ` Linus Torvalds
2009-09-01 15:08             ` [PATCH] kthreads: Fix startup synchronization boot crash Américo Wang
2009-09-01 15:19               ` Oleg Nesterov
2009-08-31  6:21 ` [PATCH] x86: detect stack protector for i386 builds on x86_64 Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-23386d63bbb3199cf247313ec088878d72debcfd@git.kernel.org \
    --to=mschmidt@redhat.com \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome