From: tip-bot for Andrey Ryabinin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: adech.fo@gmail.com, hpa@zytor.com, dvyukov@google.com,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, tglx@linutronix.de, glider@google.com,
a.ryabinin@samsung.com, bp@alien8.de, mingo@kernel.org,
alpopov@ptsecurity.com
Subject: [tip:x86/urgent] x86/kasan: Flush TLBs after switching CR3
Date: Mon, 6 Jul 2015 08:37:04 -0700 [thread overview]
Message-ID: <tip-241d2c54c62fa0939fc9a9512b48ac3434e90a89@git.kernel.org> (raw)
In-Reply-To: <1435828178-10975-4-git-send-email-a.ryabinin@samsung.com>
Commit-ID: 241d2c54c62fa0939fc9a9512b48ac3434e90a89
Gitweb: http://git.kernel.org/tip/241d2c54c62fa0939fc9a9512b48ac3434e90a89
Author: Andrey Ryabinin <a.ryabinin@samsung.com>
AuthorDate: Thu, 2 Jul 2015 12:09:35 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 6 Jul 2015 14:53:14 +0200
x86/kasan: Flush TLBs after switching CR3
load_cr3() doesn't cause tlb_flush if PGE enabled.
This may cause tons of false positive reports spamming the
kernel to death.
To fix this __flush_tlb_all() should be called explicitly
after CR3 changed.
Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: <stable@vger.kernel.org> # 4.0+
Cc: Alexander Popov <alpopov@ptsecurity.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <adech.fo@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1435828178-10975-4-git-send-email-a.ryabinin@samsung.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/mm/kasan_init_64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
index 0e4a05f..5d26642 100644
--- a/arch/x86/mm/kasan_init_64.c
+++ b/arch/x86/mm/kasan_init_64.c
@@ -208,6 +208,7 @@ void __init kasan_init(void)
memcpy(early_level4_pgt, init_level4_pgt, sizeof(early_level4_pgt));
load_cr3(early_level4_pgt);
+ __flush_tlb_all();
clear_pgds(KASAN_SHADOW_START, KASAN_SHADOW_END);
@@ -234,5 +235,6 @@ void __init kasan_init(void)
memset(kasan_zero_page, 0, PAGE_SIZE);
load_cr3(init_level4_pgt);
+ __flush_tlb_all();
init_task.kasan_depth = 0;
}
next prev parent reply other threads:[~2015-07-06 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:09 [PATCH v2 0/6] x86_64 kasan fixes Andrey Ryabinin
2015-07-02 9:09 ` [PATCH v2 1/6] x86_64, init: clear init_level4_pgt earlier Andrey Ryabinin
2015-07-06 15:36 ` [tip:x86/urgent] x86/init: Clear 'init_level4_pgt' earlier tip-bot for Andrey Ryabinin
2015-07-02 9:09 ` [PATCH v2 2/6] x86_64: kasan: fix kasan shadow region page tables Andrey Ryabinin
2015-07-06 15:36 ` [tip:x86/urgent] x86/kasan: Fix KASAN " tip-bot for Alexander Popov
2015-07-02 9:09 ` [PATCH v2 3/6] x86_64: kasan: flush tlbs after switching cr3 Andrey Ryabinin
2015-07-06 15:37 ` tip-bot for Andrey Ryabinin [this message]
2015-07-02 9:09 ` [PATCH v2 4/6] x86_64: kasan: fix boot crash on AMD processors Andrey Ryabinin
2015-07-06 15:37 ` [tip:x86/urgent] x86/kasan: Fix " tip-bot for Andrey Ryabinin
2015-07-02 9:09 ` [PATCH v2 5/6] x86_64: kasan: add message about kasan being initialized Andrey Ryabinin
2015-07-06 15:37 ` [tip:x86/urgent] x86/kasan: Add message about KASAN " tip-bot for Andrey Ryabinin
2015-07-02 9:09 ` [PATCH v2 6/6] x86_64: kasan: move KASAN_SHADOW_OFFSET to the arch Kconfig Andrey Ryabinin
2015-07-06 15:38 ` [tip:x86/urgent] x86/kasan: Move " tip-bot for Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-241d2c54c62fa0939fc9a9512b48ac3434e90a89@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=alpopov@ptsecurity.com \
--cc=bp@alien8.de \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome