From: tip-bot for John Kacur <jkacur@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
fweisbec@gmail.com, jkacur@redhat.com, vapier@gentoo.org,
tglx@linutronix.de
Subject: [tip:bkl/arch] blackfin: Remove the BKL from sys_execve
Date: Wed, 14 Oct 2009 15:46:04 GMT [thread overview]
Message-ID: <tip-25708a5fe7467dcc69d9b92c1701aad4a0c71887@git.kernel.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0910130007240.3658@localhost.localdomain>
Commit-ID: 25708a5fe7467dcc69d9b92c1701aad4a0c71887
Gitweb: http://git.kernel.org/tip/25708a5fe7467dcc69d9b92c1701aad4a0c71887
Author: John Kacur <jkacur@redhat.com>
AuthorDate: Mon, 12 Oct 2009 22:44:40 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 14 Oct 2009 17:18:14 +0200
blackfin: Remove the BKL from sys_execve
This looks like a cut-and-paste job. For example, compare this
function to sys_execve in arch/x86/kernel/process_64.c and it is
almost line by line the same, except the one in x86 nolonger has the
big kernel lock. All of the functions called between the lock are
generic and not specific to blackfin - thus, I believe it is safe to
remove the bkl here.
Signed-off-by: John Kacur <jkacur@redhat.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Mike Frysinger <vapier@gentoo.org>
LKML-Reference: <alpine.LFD.2.00.0910130007240.3658@localhost.localdomain>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/blackfin/kernel/process.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
index 430ae39..7d9c975 100644
--- a/arch/blackfin/kernel/process.c
+++ b/arch/blackfin/kernel/process.c
@@ -215,22 +215,18 @@ copy_thread(unsigned long clone_flags,
/*
* sys_execve() executes a new program.
*/
-
asmlinkage int sys_execve(char __user *name, char __user * __user *argv, char __user * __user *envp)
{
int error;
char *filename;
struct pt_regs *regs = (struct pt_regs *)((&name) + 6);
- lock_kernel();
filename = getname(name);
error = PTR_ERR(filename);
if (IS_ERR(filename))
- goto out;
+ return error;
error = do_execve(filename, argv, envp, regs);
putname(filename);
- out:
- unlock_kernel();
return error;
}
prev parent reply other threads:[~2009-10-14 15:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0910122350140.3658@localhost.localdomain>
2009-10-12 22:33 ` [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: " John Kacur
2009-10-12 22:33 ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: " John Kacur
2009-10-12 22:34 ` [PATCH 3/6 RFC] arch/h83000/kernel/process.c: Remove " John Kacur
2009-10-12 22:34 ` [PATCH 4/6 RFC] arch/m68k/kernel/process.c: Remove the " John Kacur
2009-10-12 22:34 ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " John Kacur
2009-10-12 22:35 ` [PATCH 6/6 RFC] arch/mn10300/kernel/process.c: " John Kacur
2009-10-14 15:47 ` [tip:bkl/arch] mn10300: " tip-bot for John Kacur
2009-10-13 10:44 ` [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: " Greg Ungerer
2009-10-13 11:30 ` John Kacur
2009-10-14 15:06 ` Thomas Gleixner
2009-10-14 23:39 ` Greg Ungerer
2009-10-13 16:45 ` [PATCH 6/6 RFC] arch/mn10300/kernel/process.c: " David Howells
2009-10-14 15:47 ` [tip:bkl/arch] m68knommu: " tip-bot for John Kacur
2009-10-14 15:46 ` [tip:bkl/arch] m68k: " tip-bot for John Kacur
2009-10-14 15:46 ` [tip:bkl/arch] h83000: Remove " tip-bot for John Kacur
2009-10-14 15:46 ` [tip:bkl/arch] frv: Remove the " tip-bot for John Kacur
2009-10-12 22:45 ` [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: " Frederic Weisbecker
2009-10-13 7:54 ` Mike Frysinger
2009-10-13 8:27 ` John Kacur
2009-10-13 8:35 ` Mike Frysinger
2009-10-13 8:41 ` John Kacur
2009-10-14 0:30 ` Mike Frysinger
2009-10-13 16:26 ` [PATCH 2/6 RFC] arch/frv/kernel/process.c: " David Howells
2009-10-14 15:46 ` tip-bot for John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-25708a5fe7467dcc69d9b92c1701aad4a0c71887@git.kernel.org \
--to=jkacur@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome