From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbbK2H4k (ORCPT ); Sun, 29 Nov 2015 02:56:40 -0500 Received: from terminus.zytor.com ([198.137.202.10]:39875 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbK2H4e (ORCPT ); Sun, 29 Nov 2015 02:56:34 -0500 Date: Sat, 28 Nov 2015 23:56:15 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: jolsa@redhat.com, tglx@linutronix.de, dsahern@gmail.com, hpa@zytor.com, mingo@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, a.p.zijlstra@chello.nl Reply-To: mingo@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org, a.p.zijlstra@chello.nl, tglx@linutronix.de, jolsa@redhat.com, dsahern@gmail.com, hpa@zytor.com In-Reply-To: <1448645559-31167-1-git-send-email-namhyung@kernel.org> References: <1448645559-31167-1-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf report: Show error message when processing sample fails Git-Commit-ID: 25b1606be1a910a63a23c3d1006581c9aad4e6e3 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 25b1606be1a910a63a23c3d1006581c9aad4e6e3 Gitweb: http://git.kernel.org/tip/25b1606be1a910a63a23c3d1006581c9aad4e6e3 Author: Namhyung Kim AuthorDate: Sat, 28 Nov 2015 02:32:37 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 27 Nov 2015 16:56:32 -0300 perf report: Show error message when processing sample fails Currently when perf fails to process samples for some reason, it doesn't show any message about the failure. This is very inconvenient for users especially on TUI as screen is reset after the failure. Reported-by: Ingo Molnar Signed-off-by: Namhyung Kim Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1448645559-31167-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 8a9c690..af5db88 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep) if (rep->cpu_list) { ret = perf_session__cpu_bitmap(session, rep->cpu_list, rep->cpu_bitmap); - if (ret) + if (ret) { + ui__error("failed to set cpu bitmap\n"); return ret; + } } if (rep->show_threads) perf_read_values_init(&rep->show_threads_values); ret = report__setup_sample_type(rep); - if (ret) + if (ret) { + /* report__setup_sample_type() already showed error message */ return ret; + } ret = perf_session__process_events(session); - if (ret) + if (ret) { + ui__error("failed to process sample\n"); return ret; + } report__warn_kptr_restrict(rep);