From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753056AbdBMPSa (ORCPT ); Mon, 13 Feb 2017 10:18:30 -0500 Received: from terminus.zytor.com ([65.50.211.136]:52794 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752623AbdBMPSP (ORCPT ); Mon, 13 Feb 2017 10:18:15 -0500 Date: Mon, 13 Feb 2017 07:16:48 -0800 From: tip-bot for Yang Yang Message-ID: Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, yang.yang29@zte.com.cn, peterz@infradead.org, linux-kernel@vger.kernel.org Reply-To: mingo@kernel.org, peterz@infradead.org, yang.yang29@zte.com.cn, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com In-Reply-To: <1483085875-6130-1-git-send-email-yang.yang29@zte.com.cn> References: <1483085875-6130-1-git-send-email-yang.yang29@zte.com.cn> To: linux-tip-commits@vger.kernel.org Subject: [tip:locking/urgent] futex: Move futex_init() to core_initcall Git-Commit-ID: 25f71d1c3e98ef0e52371746220d66458eac75bc X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 25f71d1c3e98ef0e52371746220d66458eac75bc Gitweb: http://git.kernel.org/tip/25f71d1c3e98ef0e52371746220d66458eac75bc Author: Yang Yang AuthorDate: Fri, 30 Dec 2016 16:17:55 +0800 Committer: Thomas Gleixner CommitDate: Mon, 13 Feb 2017 16:12:22 +0100 futex: Move futex_init() to core_initcall The UEVENT user mode helper is enabled before the initcalls are executed and is available when the root filesystem has been mounted. The user mode helper is triggered by device init calls and the executable might use the futex syscall. futex_init() is marked __initcall which maps to device_initcall, but there is no guarantee that futex_init() is invoked _before_ the first device init call which triggers the UEVENT user mode helper. If the user mode helper uses the futex syscall before futex_init() then the syscall crashes with a NULL pointer dereference because the futex subsystem has not been initialized yet. Move futex_init() to core_initcall so futexes are initialized before the root filesystem is mounted and the usermode helper becomes available. [ tglx: Rewrote changelog ] Signed-off-by: Yang Yang Cc: jiang.biao2@zte.com.cn Cc: jiang.zhengxiong@zte.com.cn Cc: zhong.weidong@zte.com.cn Cc: deng.huali@zte.com.cn Cc: Peter Zijlstra Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1483085875-6130-1-git-send-email-yang.yang29@zte.com.cn Signed-off-by: Thomas Gleixner --- kernel/futex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/futex.c b/kernel/futex.c index 0842c8ca..cdf3650 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -3323,4 +3323,4 @@ static int __init futex_init(void) return 0; } -__initcall(futex_init); +core_initcall(futex_init);