From: tip-bot for James Bottomley <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
srivatsa.bhat@linux.vnet.ibm.com, tglx@linutronix.de,
JBottomley@Parallels.com
Subject: [tip:core/urgent] idle: Enable interrupts in the weak arch_cpu_idle() implementation
Date: Wed, 19 Jun 2013 00:03:32 -0700 [thread overview]
Message-ID: <tip-29ce3785b22da47c49f4ef6e14b9014fa5dee261@git.kernel.org> (raw)
In-Reply-To: <1371236142.2726.43.camel@dabdike>
Commit-ID: 29ce3785b22da47c49f4ef6e14b9014fa5dee261
Gitweb: http://git.kernel.org/tip/29ce3785b22da47c49f4ef6e14b9014fa5dee261
Author: James Bottomley <JBottomley@Parallels.com>
AuthorDate: Wed, 8 May 2013 14:05:34 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Jun 2013 23:01:05 +0200
idle: Enable interrupts in the weak arch_cpu_idle() implementation
PARISC bootup triggers the warning at kernel/cpu/idle.c:96. That's
caused by the weak arch_cpu_idle() implementation, which is provided
to avoid that architectures implement idle_poll over and over.
The switchover to polling mode happens in the first call of the weak
arch_cpu_idle() implementation, but that code fails to reenable
interrupts and therefor triggers the warning.
Fix this by enabling interrupts in the weak arch_cpu_idle() code.
[ tglx: Made the changelog match the patch ]
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1371236142.2726.43.camel@dabdike
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/cpu/idle.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
index bf2ee1a..e695c0a 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/cpu/idle.c
@@ -59,6 +59,7 @@ void __weak arch_cpu_idle_dead(void) { }
void __weak arch_cpu_idle(void)
{
cpu_idle_force_poll = 1;
+ local_irq_enable();
}
/*
prev parent reply other threads:[~2013-06-19 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 18:55 [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96 James Bottomley
2013-06-14 19:11 ` David Daney
2013-06-14 19:13 ` James Bottomley
2013-06-14 20:39 ` Thomas Gleixner
2013-06-14 20:49 ` Thomas Gleixner
2013-06-14 21:50 ` James Bottomley
2013-06-19 7:03 ` tip-bot for James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-29ce3785b22da47c49f4ef6e14b9014fa5dee261@git.kernel.org \
--to=tipbot@zytor.com \
--cc=JBottomley@Parallels.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome