mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Dong Zhu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
	bluezhudong@gmail.com, hpa@zytor.com, mingo@kernel.org,
	tglx@linutronix.de
Subject: [tip:timers/core] timer stats: Add a 'Collection: active/inactive ' line to timer usage statistics
Date: Thu, 10 Oct 2013 04:25:17 -0700	[thread overview]
Message-ID: <tip-2cb763614c1c5baef58045af9304265075f22d0a@git.kernel.org> (raw)
In-Reply-To: <20131010075618.GH2139@zhudong.nay.redhat.com>

Commit-ID:  2cb763614c1c5baef58045af9304265075f22d0a
Gitweb:     http://git.kernel.org/tip/2cb763614c1c5baef58045af9304265075f22d0a
Author:     Dong Zhu <bluezhudong@gmail.com>
AuthorDate: Thu, 10 Oct 2013 15:56:18 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 10 Oct 2013 09:59:25 +0200

timer stats: Add a 'Collection: active/inactive' line to timer usage statistics

We can enable/disable timer statistics collection via:

  echo [1|0] > /proc/timers_stats

and it would be nice if apps had the ability to check
what the current collection status is.

This patch adds a 'Collection: active/inactive' line to display the
current timer collection status.

Also bump up the timer stats version to v0.3.

Signed-off-by: Dong Zhu <bluezhudong@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/20131010075618.GH2139@zhudong.nay.redhat.com
[ Improved the changelog and the code. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/time/timer_stats.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
index 0b537f2..1fb08f2 100644
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -298,15 +298,15 @@ static int tstats_show(struct seq_file *m, void *v)
 	period = ktime_to_timespec(time);
 	ms = period.tv_nsec / 1000000;
 
-	seq_puts(m, "Timer Stats Version: v0.2\n");
+	seq_puts(m, "Timer Stats Version: v0.3\n");
 	seq_printf(m, "Sample period: %ld.%03ld s\n", period.tv_sec, ms);
 	if (atomic_read(&overflow_count))
-		seq_printf(m, "Overflow: %d entries\n",
-			atomic_read(&overflow_count));
+		seq_printf(m, "Overflow: %d entries\n", atomic_read(&overflow_count));
+	seq_printf(m, "Collection: %s\n", timer_stats_active ? "active" : "inactive");
 
 	for (i = 0; i < nr_entries; i++) {
 		entry = entries + i;
- 		if (entry->timer_flag & TIMER_STATS_FLAG_DEFERRABLE) {
+		if (entry->timer_flag & TIMER_STATS_FLAG_DEFERRABLE) {
 			seq_printf(m, "%4luD, %5d %-16s ",
 				entry->count, entry->pid, entry->comm);
 		} else {

      reply	other threads:[~2013-10-10 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  2:59 [PATCH RESEND] timer stats: reset entries when disable the " Dong Zhu
2013-10-10  4:04 ` John Stultz
2013-10-10  4:35 ` Ingo Molnar
2013-10-10  4:48   ` John Stultz
2013-10-10  6:14   ` [PATCH v2] timer stats: add a 'status' line to " Dong Zhu
2013-10-10  6:16     ` Ingo Molnar
2013-10-10  6:55       ` [PATCH v0.3] " Dong Zhu
2013-10-10  7:26         ` Ingo Molnar
2013-10-10  7:56           ` [PATCH v4] " Dong Zhu
2013-10-10 11:25             ` tip-bot for Dong Zhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-2cb763614c1c5baef58045af9304265075f22d0a@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=bluezhudong@gmail.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome