From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbdKLWdz (ORCPT ); Sun, 12 Nov 2017 17:33:55 -0500 Received: from terminus.zytor.com ([65.50.211.136]:40257 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbdKLWdy (ORCPT ); Sun, 12 Nov 2017 17:33:54 -0500 Date: Sun, 12 Nov 2017 14:31:42 -0800 From: tip-bot for Rasmus Villemoes Message-ID: Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, marc.zyngier@arm.com, tglx@linutronix.de, linux@rasmusvillemoes.dk Reply-To: linux@rasmusvillemoes.dk, tglx@linutronix.de, marc.zyngier@arm.com, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com In-Reply-To: <20171112212904.28574-1-linux@rasmusvillemoes.dk> References: <20171112212904.28574-1-linux@rasmusvillemoes.dk> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] irqdomain: Drop pointless NULL check in virq_debug_show_one Git-Commit-ID: 306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4 Gitweb: https://git.kernel.org/tip/306eb5a38dfc1a4c8a5c910c9844da6a97f2b9a4 Author: Rasmus Villemoes AuthorDate: Sun, 12 Nov 2017 22:29:03 +0100 Committer: Thomas Gleixner CommitDate: Sun, 12 Nov 2017 23:25:40 +0100 irqdomain: Drop pointless NULL check in virq_debug_show_one data has been already derefenced unconditionally, so it's pointless to do a NULL pointer check on it afterwards. Drop it. [ tglx: Depersonify changelog. ] Signed-off-by: Rasmus Villemoes Signed-off-by: Thomas Gleixner Cc: Marc Zyngier Link: https://lkml.kernel.org/r/20171112212904.28574-1-linux@rasmusvillemoes.dk --- kernel/irq/irqdomain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index fbbf342..4f4f600 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -921,8 +921,7 @@ static void virq_debug_show_one(struct seq_file *m, struct irq_desc *desc) chip = irq_data_get_irq_chip(data); seq_printf(m, "%-15s ", (chip && chip->name) ? chip->name : "none"); - seq_printf(m, data ? "0x%p " : " %p ", - irq_data_get_irq_chip_data(data)); + seq_printf(m, "0x%p ", irq_data_get_irq_chip_data(data)); seq_printf(m, " %c ", (desc->action && desc->action->handler) ? '*' : ' '); direct = (irq == hwirq) && (irq < domain->revmap_direct_max_irq);