From: tip-bot for Jiri Slaby <jslaby@suse.cz>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
stable@kernel.org, aaw@google.com, tglx@linutronix.de,
jslaby@suse.cz, mingo@elte.hu
Subject: [tip:x86/urgent] x86, ia32_aout: do not kill argument mapping
Date: Wed, 10 Feb 2010 21:30:39 GMT [thread overview]
Message-ID: <tip-318f6b228ba88a394ef560efc1bfe028ad5ae6b6@git.kernel.org> (raw)
In-Reply-To: <1265831716-7668-1-git-send-email-jslaby@suse.cz>
Commit-ID: 318f6b228ba88a394ef560efc1bfe028ad5ae6b6
Gitweb: http://git.kernel.org/tip/318f6b228ba88a394ef560efc1bfe028ad5ae6b6
Author: Jiri Slaby <jslaby@suse.cz>
AuthorDate: Wed, 10 Feb 2010 20:55:16 +0100
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Wed, 10 Feb 2010 12:03:34 -0800
x86, ia32_aout: do not kill argument mapping
Do not set current->mm->mmap to NULL in 32-bit emulation on 64-bit
load_aout_binary after flush_old_exec as it would destroy already
set brpm mapping with arguments.
Introduced by b6a2fea39318e43fee84fa7b0b90d68bed92d2ba
mm: variable length argument support
where the argument mapping in bprm was added.
[ hpa: this is a regression from 2.6.22... time to kill a.out? ]
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
LKML-Reference: <1265831716-7668-1-git-send-email-jslaby@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ollie Wild <aaw@google.com>
Cc: x86@kernel.org
Cc: <stable@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/ia32/ia32_aout.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c
index f9f4724..14531ab 100644
--- a/arch/x86/ia32/ia32_aout.c
+++ b/arch/x86/ia32/ia32_aout.c
@@ -327,7 +327,6 @@ static int load_aout_binary(struct linux_binprm *bprm, struct pt_regs *regs)
current->mm->free_area_cache = TASK_UNMAPPED_BASE;
current->mm->cached_hole_size = 0;
- current->mm->mmap = NULL;
install_exec_creds(bprm);
current->flags &= ~PF_FORKNOEXEC;
prev parent reply other threads:[~2010-02-10 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 19:55 [PATCH -resend 1/1] x86: ia32_aout, " Jiri Slaby
2010-02-10 21:30 ` tip-bot for Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-318f6b228ba88a394ef560efc1bfe028ad5ae6b6@git.kernel.org \
--to=jslaby@suse.cz \
--cc=aaw@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®