From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbdFZOFu (ORCPT ); Mon, 26 Jun 2017 10:05:50 -0400 Received: from terminus.zytor.com ([65.50.211.136]:54893 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbdFZOFm (ORCPT ); Mon, 26 Jun 2017 10:05:42 -0400 Date: Mon, 26 Jun 2017 07:04:28 -0700 From: tip-bot for Christophe JAILLET Message-ID: Cc: hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, tglx@linutronix.de Reply-To: christophe.jaillet@wanadoo.fr, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org In-Reply-To: <20170623062440.6726-1-christophe.jaillet@wanadoo.fr> References: <20170623062440.6726-1-christophe.jaillet@wanadoo.fr> To: linux-tip-commits@vger.kernel.org Subject: [tip:ras/core] RAS/CEC: Check the correct variable in the debugfs error handling Git-Commit-ID: 32288daf3f2439f57167c03cd679c2eba28923b7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 32288daf3f2439f57167c03cd679c2eba28923b7 Gitweb: http://git.kernel.org/tip/32288daf3f2439f57167c03cd679c2eba28923b7 Author: Christophe JAILLET AuthorDate: Mon, 26 Jun 2017 14:35:32 +0200 Committer: Thomas Gleixner CommitDate: Mon, 26 Jun 2017 15:58:57 +0200 RAS/CEC: Check the correct variable in the debugfs error handling Check the correct variable when handling a potential error from debugfs_create_file(). Most likely a copy-paste botch. [ Rewrite commit message. ] Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector") Signed-off-by: Christophe JAILLET Signed-off-by: Borislav Petkov Signed-off-by: Thomas Gleixner Link: http://lkml.kernel.org/r/20170623062440.6726-1-christophe.jaillet@wanadoo.fr --- drivers/ras/cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index 6aab46d..d0e5d6e 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -481,7 +481,7 @@ static int __init create_debugfs_nodes(void) count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d, &count_threshold, &count_threshold_ops); - if (!decay) { + if (!count) { pr_warn("Error creating count_threshold debugfs node!\n"); goto err; }