mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Masami Hiramatsu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
	mingo@redhat.com, hpa@zytor.com, mingo@kernel.org,
	a.p.zijlstra@chello.nl, naota@elisp.net, namhyung@kernel.org,
	masami.hiramatsu.pt@hitachi.com, tglx@linutronix.de
Subject: [tip:perf/core] perf record: Use strerror_r instead of strerror
Date: Mon, 18 Aug 2014 01:24:17 -0700	[thread overview]
Message-ID: <tip-35550da389ba8752f024a44ef14b74001c4fc4d3@git.kernel.org> (raw)
In-Reply-To: <20140814022243.3545.7411.stgit@kbuild-fedora.novalocal>

Commit-ID:  35550da389ba8752f024a44ef14b74001c4fc4d3
Gitweb:     http://git.kernel.org/tip/35550da389ba8752f024a44ef14b74001c4fc4d3
Author:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Thu, 14 Aug 2014 02:22:43 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Aug 2014 13:07:14 -0300

perf record: Use strerror_r instead of strerror

Use strerror_r instead of strerror in error messages for thread-safety.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022243.3545.7411.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-record.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 4db670d..87e28a4 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -161,7 +161,7 @@ try_again:
 
 	if (perf_evlist__apply_filters(evlist)) {
 		error("failed to set filter with %d (%s)\n", errno,
-			strerror(errno));
+			strerror_r(errno, msg, sizeof(msg)));
 		rc = -1;
 		goto out;
 	}
@@ -175,7 +175,8 @@ try_again:
 			       "(current value: %u)\n", opts->mmap_pages);
 			rc = -errno;
 		} else {
-			pr_err("failed to mmap with %d (%s)\n", errno, strerror(errno));
+			pr_err("failed to mmap with %d (%s)\n", errno,
+				strerror_r(errno, msg, sizeof(msg)));
 			rc = -errno;
 		}
 		goto out;
@@ -480,7 +481,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
 	}
 
 	if (forks && workload_exec_errno) {
-		char msg[512];
+		char msg[STRERR_BUFSIZE];
 		const char *emsg = strerror_r(workload_exec_errno, msg, sizeof(msg));
 		pr_err("Workload failed: %s\n", emsg);
 		err = -1;

  reply	other threads:[~2014-08-18  8:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  2:22 [PATCH 00/13] perf: Replace strerror with strerror_r for thread-safety Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 01/13] perf probe: Don't use strerror if strlist__add failed Masami Hiramatsu
2014-08-18  8:22   ` [tip:perf/core] perf probe: Don' t " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 02/13] perf: Use strerror_r instead of strerror Masami Hiramatsu
2014-08-18  8:23   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 03/13] perf probe: Make error messages thread-safe Masami Hiramatsu
2014-08-18  8:23   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 04/13] perf/util: Replace strerror with strerror_r for thread-safety Masami Hiramatsu
2014-08-18  8:23   ` [tip:perf/core] perf util: " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 05/13] perf top: Use strerror_r instead of strerror Masami Hiramatsu
2014-08-18  8:23   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 06/13] perf trace: " Masami Hiramatsu
2014-08-18  8:24   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 07/13] perf record: " Masami Hiramatsu
2014-08-18  8:24   ` tip-bot for Masami Hiramatsu [this message]
2014-08-14  2:22 ` [PATCH 08/13] perf test: " Masami Hiramatsu
2014-08-18  8:24   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 09/13] perf sched: " Masami Hiramatsu
2014-08-18  8:24   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 10/13] perf buildid-cache: " Masami Hiramatsu
2014-08-18  8:25   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 11/13] perf kvm: " Masami Hiramatsu
2014-08-18  8:25   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 12/13] perf help: " Masami Hiramatsu
2014-08-18  8:25   ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2014-08-14  2:22 ` [PATCH 13/13] perf stat: " Masami Hiramatsu
2014-08-18  8:25   ` [tip:perf/core] " tip-bot for Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-35550da389ba8752f024a44ef14b74001c4fc4d3@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naota@elisp.net \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®