From: tip-bot for Don Zickus <dzickus@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, tglx@linutronix.de, dzickus@redhat.com
Subject: [tip:x86/reboot] x86/reboot: Update nonmi_ipi parameter
Date: Mon, 14 May 2012 06:06:30 -0700 [thread overview]
Message-ID: <tip-3aac27aba79b7c52e709ef6de0f7d8139caedc01@git.kernel.org> (raw)
In-Reply-To: <1336761675-24296-4-git-send-email-dzickus@redhat.com>
Commit-ID: 3aac27aba79b7c52e709ef6de0f7d8139caedc01
Gitweb: http://git.kernel.org/tip/3aac27aba79b7c52e709ef6de0f7d8139caedc01
Author: Don Zickus <dzickus@redhat.com>
AuthorDate: Fri, 11 May 2012 14:41:15 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 14 May 2012 11:49:38 +0200
x86/reboot: Update nonmi_ipi parameter
Update the nonmi_ipi parameter to reflect the simple change
instead of the previous complicated one. There should be less
of a need to use it but there may still be corner cases on older
hardware that stumble into NMI issues.
Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1336761675-24296-4-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/smp.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 228e740..48d2b7d 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -110,6 +110,7 @@
*/
static atomic_t stopping_cpu = ATOMIC_INIT(-1);
+static bool smp_no_nmi_ipi = false;
/*
* this function sends a 'reschedule' IPI to another CPU.
@@ -216,7 +217,7 @@ static void native_stop_other_cpus(int wait)
}
/* if the REBOOT_VECTOR didn't work, try with the NMI */
- if ((num_online_cpus() > 1)) {
+ if ((num_online_cpus() > 1) && (!smp_no_nmi_ipi)) {
if (register_nmi_handler(NMI_LOCAL, smp_stop_nmi_callback,
NMI_FLAG_FIRST, "smp_stop"))
/* Note: we ignore failures here */
@@ -245,11 +246,6 @@ finish:
local_irq_restore(flags);
}
-static void native_smp_disable_nmi_ipi(void)
-{
- smp_ops.stop_other_cpus = native_irq_stop_other_cpus;
-}
-
/*
* Reschedule call back.
*/
@@ -283,8 +279,8 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
static int __init nonmi_ipi_setup(char *str)
{
- native_smp_disable_nmi_ipi();
- return 1;
+ smp_no_nmi_ipi = true;
+ return 1;
}
__setup("nonmi_ipi", nonmi_ipi_setup);
prev parent reply other threads:[~2012-05-14 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 18:41 [PATCH 0/3] x86, reboot: Modify shutting down cpus Don Zickus
2012-05-11 18:41 ` [PATCH 1/3] Revert "x86, reboot: Use NMI instead of REBOOT_VECTOR to stop cpus" Don Zickus
2012-05-14 13:04 ` [tip:x86/reboot] " tip-bot for Don Zickus
2012-05-11 18:41 ` [PATCH 2/3] x86, reboot: Use NMI to assist in shutting down if IRQ fails Don Zickus
2012-05-14 13:05 ` [tip:x86/reboot] x86/reboot: " tip-bot for Don Zickus
2012-05-11 18:41 ` [PATCH 3/3] x86, reboot: Update nonmi_ipi parameter Don Zickus
2012-05-14 13:06 ` tip-bot for Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3aac27aba79b7c52e709ef6de0f7d8139caedc01@git.kernel.org \
--to=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome