From: tip-bot for Minghuan Lian <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jason@lakedaemon.net, Minghuan.Lian@freescale.com,
linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
stuart.yoder@freescale.com, linux-arm-kernel@lists.infradead.org,
hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de
Subject: [tip:irq/urgent] irqchip/gicv3-its: ITS table size should not be smaller than PSZ
Date: Wed, 20 May 2015 13:15:29 -0700 [thread overview]
Message-ID: <tip-3ad2a5f57656a14d964b673a5a0e4ab0e583c870@git.kernel.org> (raw)
In-Reply-To: <1432134795-661-1-git-send-email-stuart.yoder@freescale.com>
Commit-ID: 3ad2a5f57656a14d964b673a5a0e4ab0e583c870
Gitweb: http://git.kernel.org/tip/3ad2a5f57656a14d964b673a5a0e4ab0e583c870
Author: Minghuan Lian <Minghuan.Lian@freescale.com>
AuthorDate: Wed, 20 May 2015 10:13:15 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 20 May 2015 22:13:37 +0200
irqchip/gicv3-its: ITS table size should not be smaller than PSZ
When allocating a device table, if the requested allocation is smaller
than the default granule size of the ITS then, we need to round up to
the default size.
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
[ stuart: Added comments and massaged changelog ]
Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
Reviewed-by: Marc Zygnier <marc.zyngier@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>
Cc: <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1432134795-661-1-git-send-email-stuart.yoder@freescale.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-gic-v3-its.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 9687f8a..1b7e155 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -828,7 +828,14 @@ static int its_alloc_tables(struct its_node *its)
u64 typer = readq_relaxed(its->base + GITS_TYPER);
u32 ids = GITS_TYPER_DEVBITS(typer);
- order = get_order((1UL << ids) * entry_size);
+ /*
+ * 'order' was initialized earlier to the default page
+ * granule of the the ITS. We can't have an allocation
+ * smaller than that. If the requested allocation
+ * is smaller, round up to the default page granule.
+ */
+ order = max(get_order((1UL << ids) * entry_size),
+ order);
if (order >= MAX_ORDER) {
order = MAX_ORDER - 1;
pr_warn("%s: Device Table too large, reduce its page order to %u\n",
prev parent reply other threads:[~2015-05-20 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:13 [RESEND][ PATCH v3] " Stuart Yoder
2015-05-20 19:25 ` Thomas Gleixner
[not found] ` <CY1PR0301MB074800AFD74B97267DD71BA287C20@CY1PR0301MB0748.namprd03.prod.outlook.com>
2015-05-20 20:03 ` Jason Cooper
2015-05-20 20:09 ` Thomas Gleixner
2015-05-20 20:15 ` tip-bot for Minghuan Lian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3ad2a5f57656a14d964b673a5a0e4ab0e583c870@git.kernel.org \
--to=tipbot@zytor.com \
--cc=Minghuan.Lian@freescale.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=stuart.yoder@freescale.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome