From: tip-bot for Thomas Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@alien8.de, hpa@zytor.com, umgwanakikbuti@gmail.com,
mingo@kernel.org, tglx@linutronix.de, aherrmann@suse.com,
jencce.kernel@gmail.com, linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/topology: Use total_cpus not nr_cpu_ids for logical packages
Date: Sat, 19 Mar 2016 02:31:29 -0700 [thread overview]
Message-ID: <tip-3e8db2246b434c6b18a6a9f09904038bddcf76c7@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1603181254330.3978@nanos>
Commit-ID: 3e8db2246b434c6b18a6a9f09904038bddcf76c7
Gitweb: http://git.kernel.org/tip/3e8db2246b434c6b18a6a9f09904038bddcf76c7
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Fri, 18 Mar 2016 17:20:30 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sat, 19 Mar 2016 10:26:40 +0100
x86/topology: Use total_cpus not nr_cpu_ids for logical packages
nr_cpu_ids can be limited on the command line via nr_cpus=. That can break the
logical package management because it results in a smaller number of packages,
but the cpus to online are occupying the full package space as the hyper
threads are enumerated after the physical cores typically.
total_cpus is the real possible cpu space not limited by nr_cpus command line
and gives us the proper number of packages.
Reported-by: Mike Galbraith <umgwanakikbuti@gmail.com>
Fixes: 1f12e32f4cd5 ("x86/topology: Create logical package id")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Xiong Zhou <jencce.kernel@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Andreas Herrmann <aherrmann@suse.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1603181254330.3978@nanos
---
arch/x86/kernel/smpboot.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 81e6a43..b2c99f8 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -325,9 +325,14 @@ static void __init smp_init_package_map(void)
* By not including this we'll sometimes over-estimate the number of
* logical packages by the amount of !present siblings, but this is
* still better than MAX_LOCAL_APIC.
+ *
+ * We use total_cpus not nr_cpu_ids because nr_cpu_ids can be limited
+ * on the command line leading to a similar issue as the HT disable
+ * problem because the hyperthreads are usually enumerated after the
+ * primary cores.
*/
ncpus = boot_cpu_data.x86_max_cores;
- __max_logical_packages = DIV_ROUND_UP(nr_cpu_ids, ncpus);
+ __max_logical_packages = DIV_ROUND_UP(total_cpus, ncpus);
/*
* Possibly larger than what we need as the number of apic ids per
next prev parent reply other threads:[~2016-03-19 9:35 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 6:48 4.5.0+ panic when setup loop device Xiong Zhou
2016-03-16 15:26 ` Thomas Gleixner
2016-03-17 1:56 ` Xiong Zhou
2016-03-17 9:52 ` Peter Zijlstra
2016-03-17 9:56 ` Peter Zijlstra
2016-03-17 10:21 ` Thomas Gleixner
2016-03-17 10:26 ` Peter Zijlstra
2016-03-17 11:39 ` Thomas Gleixner
2016-03-17 11:51 ` Peter Zijlstra
2016-03-17 11:57 ` Borislav Petkov
2016-03-17 12:01 ` Thomas Gleixner
2016-03-17 16:42 ` Jens Axboe
2016-03-17 18:26 ` Jens Axboe
2016-03-17 20:20 ` Thomas Gleixner
2016-03-17 20:23 ` Jens Axboe
2016-03-17 20:30 ` Thomas Gleixner
2016-03-17 20:41 ` Jens Axboe
2016-03-18 2:31 ` Xiong Zhou
2016-03-18 4:11 ` Mike Galbraith
2016-03-18 7:51 ` Peter Zijlstra
2016-03-18 10:15 ` Peter Zijlstra
2016-03-18 12:39 ` Mike Galbraith
2016-03-18 13:32 ` Peter Zijlstra
2016-03-18 14:07 ` Mike Galbraith
2016-03-18 11:55 ` Thomas Gleixner
2016-03-18 12:39 ` Mike Galbraith
2016-03-19 9:31 ` tip-bot for Thomas Gleixner [this message]
2016-03-29 8:48 ` [tip:x86/urgent] x86/topology: Fix AMD core count tip-bot for Peter Zijlstra
2016-03-18 15:03 [PATCH 0/3] x86 topology fixes Peter Zijlstra
2016-03-18 15:03 ` [PATCH 1/3] x86/topology: Fix logical pkg mapping Peter Zijlstra
2016-03-19 9:30 ` [tip:x86/urgent] x86/topology: Fix logical package mapping tip-bot for Peter Zijlstra
2016-03-18 15:03 ` [PATCH 2/3] x86/topology: Fix AMD core count Peter Zijlstra
2016-03-18 16:41 ` Borislav Petkov
2016-03-21 3:07 ` Huang Rui
2016-03-21 3:46 ` Huang Rui
2016-03-21 8:26 ` Borislav Petkov
2016-03-21 9:18 ` Huang Rui
2016-03-21 8:56 ` Thomas Gleixner
2016-03-21 8:21 ` Peter Zijlstra
2016-03-21 9:46 ` Huang Rui
2016-03-21 13:57 ` Borislav Petkov
2016-03-22 8:10 ` Sherry Hurwitz
2016-03-22 11:22 ` Borislav Petkov
2016-03-21 8:23 ` Borislav Petkov
2016-03-21 10:05 ` Huang Rui
2016-03-21 10:23 ` Borislav Petkov
2016-03-19 9:24 ` Thomas Gleixner
2016-03-19 15:56 ` Borislav Petkov
2016-03-20 10:39 ` Peter Zijlstra
2016-03-20 11:04 ` Borislav Petkov
2016-03-20 12:32 ` Peter Zijlstra
2016-03-20 12:46 ` Peter Zijlstra
2016-03-20 13:09 ` Borislav Petkov
2016-03-20 17:08 ` Peter Zijlstra
2016-03-20 18:46 ` Borislav Petkov
2016-03-29 8:49 ` [tip:x86/urgent] perf/x86/amd: Cleanup Fam10h NB event constraints tip-bot for Peter Zijlstra
2016-03-22 7:56 ` [PATCH 2/3] x86/topology: Fix AMD core count Huang Rui
2016-03-18 15:03 ` [PATCH 3/3] x86/topology: Fix Intel HT disable Peter Zijlstra
2016-03-19 9:31 ` [tip:x86/urgent] " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3e8db2246b434c6b18a6a9f09904038bddcf76c7@git.kernel.org \
--to=tipbot@zytor.com \
--cc=aherrmann@suse.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome